Introduce .isMalformed

pkg/compiler/lib/src/ssa/builder.dart

Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index bb00a2640caf363cc5a45d4592002585afbc3269..a9b72e69d4bdd72f1e26b52554de1e2efe9831ff 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -2022,7 +2022,7 @@ class SsaBuilder extends ast.Visitor
       }
 
       Element target = constructor.definingConstructor.implementation;
-      bool match = !target.isErroneous &&
+      bool match = !target.isMalformed &&
           CallStructure.addForwardingElementArgumentsToList(
               constructor,
               arguments,
@@ -3475,7 +3475,7 @@ class SsaBuilder extends ast.Visitor
       handleInvalidStaticGet(node, element);
     } else {
       // This happens when [element] has parse errors.
-      assert(invariant(node, element == null || element.isErroneous));
+      assert(invariant(node, element == null || element.isMalformed));
       // TODO(ahe): Do something like the above, that is, emit a runtime
       // error.
       stack.add(graph.addConstantNull(compiler));
@@ -3764,7 +3764,7 @@ class SsaBuilder extends ast.Visitor
         addWithPosition(new HStaticStore(element, value), location);
       }
       stack.add(value);
-    } else if (Elements.isErroneous(element)) {
+    } else if (Elements.isMalformed(element)) {

[Johnni Winther, 2015/10/21 07:51:56]

Change to

} else if (Elements.isError(element)) {
  generateNoSuchSetter(...);
} else if (Elements.isMalformed(element)) {
  // TODO(...

[sigurdm, 2015/10/22 07:33:14]

Done.

       if (element is ErroneousElement) {
         generateNoSuchSetter(location, element,  send == null ? null : value);
       } else {
@@ -5136,7 +5136,7 @@ class SsaBuilder extends ast.Visitor
     // TODO(5347): Try to avoid the need for calling [implementation] before
     // calling [makeStaticArgumentList].
     constructorImplementation = constructor.implementation;
-    if (constructorImplementation.isErroneous ||
+    if (constructorImplementation.isMalformed ||
         !callStructure.signatureApplies(
             constructorImplementation.functionSignature)) {
       generateWrongArgumentCountError(send, constructor, send.arguments);
@@ -5724,11 +5724,11 @@ class SsaBuilder extends ast.Visitor
   void bulkHandleNew(ast.NewExpression node, [_]) {
     Element element = elements[node.send];
     final bool isSymbolConstructor = element == compiler.symbolConstructor;
-    if (!Elements.isErroneous(element)) {
+    if (!Elements.isMalformed(element)) {
       ConstructorElement function = element;
       element = function.effectiveTarget;
     }
-    if (Elements.isErroneous(element)) {
+    if (Elements.isMalformed(element)) {

[Johnni Winther, 2015/10/21 07:51:56]

Change to

if (Elements.isError(element)) {
  ErroneousElement error ...
  ...
} else if (Elements.isMalformed(element)) {
  // TODO(...

[sigurdm, 2015/10/22 07:33:14]

Done.

       if (element is !ErroneousElement) {
         // TODO(ahe): Do something like [generateWrongArgumentCountError].
         stack.add(graph.addConstantNull(compiler));
@@ -6881,7 +6881,7 @@ class SsaBuilder extends ast.Visitor
       return;
     }
 
-    if (getter.isErroneous) {
+    if (getter.isMalformed) {
       generateStaticUnresolvedGet(node, getter);
     } else if (getter.isField) {
       generateStaticFieldGet(node, getter);