Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: tools/dom/scripts/generator.py

Issue 1414903007: Serialize the data argument to History's state-related APIs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add a TODO Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/history_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/generator.py
diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py
index 2cdc750cb08df551f60a4c1c003a785f62db9a7d..0f8867d0d14589c5e1a9dfe9e3e33c3f3f15a52f 100644
--- a/tools/dom/scripts/generator.py
+++ b/tools/dom/scripts/generator.py
@@ -732,6 +732,12 @@ dart2js_conversions = monitored.Dict('generator.dart2js_conversions', {
Conversion('convertNativeToDart_SerializedScriptValue',
'dynamic', 'dynamic'),
+ # TODO(alanknight): This generates two variations for dart2js, because of
+ # the optional argument, but not in Dartium. Should do the same for both.
+ 'any set History.pushState': _serialize_SSV,
+
+ 'any set History.replaceState': _serialize_SSV,
+
'* get History.state':
Conversion('convertNativeToDart_SerializedScriptValue',
'dynamic', 'dynamic'),
@@ -1443,6 +1449,7 @@ def wrap_unwrap_type_blink(return_type, type_registry):
return_type = return_type.replace('Html', 'HTML', 1)
return (type_registry.HasInterface(return_type) or not(return_type) or
return_type == 'Object' or
+ return_type == 'dynamic' or
return_type == 'Future' or
return_type == 'SqlDatabase' or # renamed to Database
return_type == 'HTMLElement' or
« no previous file with comments | « tests/html/history_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698