sdk/lib/html/dartium/html_dartium.dart - Issue 1414903007: Serialize the data argument to History's state-related APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 1414903007: Serialize the data argument to History's state-related APIs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add a TODO Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index 0c2df1871d548db8ac194923c653d539e938d814..0459d733d2848f53478669f1166ff5c9f2b76573 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -19940,7 +19940,7 @@ class History extends DartHtmlDomObject implements HistoryBase {

@DomName('History.state')

@DocsEditable()

- dynamic get state => _blink.BlinkHistory.instance.state_Getter_(unwrap_jso(this));

+ dynamic get state => wrap_jso(_blink.BlinkHistory.instance.state_Getter_(unwrap_jso(this)));

@DomName('History.back')

@DocsEditable()

@@ -19960,7 +19960,7 @@ class History extends DartHtmlDomObject implements HistoryBase {

@SupportedBrowser(SupportedBrowser.FIREFOX)

@SupportedBrowser(SupportedBrowser.IE, '10')

@SupportedBrowser(SupportedBrowser.SAFARI)

- void pushState(Object data, String title, [String url]) => _blink.BlinkHistory.instance.pushState_Callback_3_(unwrap_jso(this), data, title, url);

+ void pushState(Object data, String title, [String url]) => _blink.BlinkHistory.instance.pushState_Callback_3_(unwrap_jso(this), convertDartToNative_SerializedScriptValue(data), title, url);

@DomName('History.replaceState')

@DocsEditable()

@@ -19968,7 +19968,7 @@ class History extends DartHtmlDomObject implements HistoryBase {

@SupportedBrowser(SupportedBrowser.FIREFOX)

@SupportedBrowser(SupportedBrowser.IE, '10')

@SupportedBrowser(SupportedBrowser.SAFARI)

- void replaceState(Object data, String title, [String url]) => _blink.BlinkHistory.instance.replaceState_Callback_3_(unwrap_jso(this), data, title, url);

+ void replaceState(Object data, String title, [String url]) => _blink.BlinkHistory.instance.replaceState_Callback_3_(unwrap_jso(this), convertDartToNative_SerializedScriptValue(data), title, url);

}

« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/history_test.dart » ('j') | no next file with comments »