Issue 1414903006: Add buildtools to make depot_tools-wrapped clang-format work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1414903006: Add buildtools to make depot_tools-wrapped clang-format work (Closed)

Created:
5 years, 1 month ago by Mark Mentovai

Modified:
5 years, 1 month ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Add buildtools to make depot_tools-wrapped clang-format work Crashpad is mostly friendly with clang-format and has its own .clang-format file. Adding buildtools makes it possible to use the depot_tools clang-format wrapper. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/20045d38679c35f3b5886c665706dac4cbb003b4

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	DEPS	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

Since I’ve been doing more Windows work recently, I got tired of having to switch ...

5 years, 1 month ago (2015-11-05 17:51:33 UTC) #2

scottmg

I'd just been setting my cwd to my chrome tree which mostly works-ish. But this ...

5 years, 1 month ago (2015-11-05 18:04:37 UTC) #3

Mark Mentovai

5 years, 1 month ago (2015-11-05 18:48:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
20045d38679c35f3b5886c665706dac4cbb003b4 (presubmit successful).