Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1414903005: Begin generating code for summary serialization/deserialization. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin generating code for summary serialization/deserialization. The generated code is not yet used. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9d550c4a0f6035d50ce2ea30457614e527070f88

Patch Set 1 #

Patch Set 2 : Fix handling of List<int> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1793 lines, -66 lines) Patch
A pkg/analyzer/lib/src/summary/builder.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/summary/format.dart View 1 1 chunk +1280 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/generate_files View 1 chunk +1 line, -0 lines 0 comments Download
A + pkg/analyzer/tool/summary/check_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A pkg/analyzer/tool/summary/generate.dart View 1 1 chunk +345 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 7 chunks +74 lines, -63 lines 0 comments Download
A pkg/analyzer/tool/summary/idl_model.dart View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paul Berry
5 years, 1 month ago (2015-11-04 17:37:43 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-04 18:03:23 UTC) #3
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-04 18:03:23 UTC) #4
scheglov
LGTM
5 years, 1 month ago (2015-11-04 18:04:12 UTC) #5
Paul Berry
5 years, 1 month ago (2015-11-04 18:22:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9d550c4a0f6035d50ce2ea30457614e527070f88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698