Dependencies are now added between the drawTargets in GrPipeline

Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)

BUG=skia:4094
Committed: https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be

Committed: https://skia.googlesource.com/skia/+/869c5e82a725a6928a45cd1fa6945ac783b8b3d8

Committed: https://skia.googlesource.com/skia/+/498d7ac86bfb45bdfc8f9aa7424f7236235987b5

[robertphillips, 2015-10-20 13:08:14]

Description was changed from

==========
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery
to GrDrawTarget to enable topological sorting)

BUG=skia:4094
==========

to

==========
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery
to GrDrawTarget to enable topological sorting)

BUG=skia:4094
==========

[robertphillips, 2015-10-20 13:08:14]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-10-20 15:05:48]

Patchset #3 (id:40001) has been deleted

[robertphillips, 2015-10-20 15:11:04]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 15:11:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/60001

[commit-bot: I haz the power, 2015-10-20 15:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 15:12:07]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2015-10-20 15:14:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 15:14:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/80001

[commit-bot: I haz the power, 2015-10-20 15:23:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 15:23:42]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-20 19:12:01]

ping

[bsalomon, 2015-10-20 19:51:07]

lgtm

[robertphillips, 2015-10-20 20:23:53]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-10-20 20:24:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/80001

[robertphillips, 2015-10-20 20:25:00]

The CQ bit was unchecked by robertphillips@google.com

[commit-bot: I haz the power, 2015-10-20 20:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 20:25:01]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2015-10-20 20:29:30]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 20:29:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/100001

[commit-bot: I haz the power, 2015-10-20 20:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 20:39:20]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-20 20:40:26]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-10-20 20:40:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1414903002/#ps100001
(title: "update to ToT")

[commit-bot: I haz the power, 2015-10-20 20:40:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/100001

[commit-bot: I haz the power, 2015-10-20 20:41:19]

Committed patchset #5 (id:100001) as
https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be

[caryclark, 2015-10-21 11:16:06]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/1419613005/ by caryclark@google.com.

The reason for reverting is: this may have broken the TSAN and ASAN bots.

[robertphillips, 2015-10-21 11:58:46]

Description was changed from

==========
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery
to GrDrawTarget to enable topological sorting)

BUG=skia:4094

Committed:
https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be
==========

to

==========
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery
to GrDrawTarget to enable topological sorting)

BUG=skia:4094

Committed:
https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be
==========

[robertphillips, 2015-10-21 21:17:18]

Brian do you want to take a look at PS6? This fixes the lifetime problem in
valgrind.

[robertphillips, 2015-10-22 11:50:36]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 11:50:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/120001

[robertphillips, 2015-10-22 12:10:27]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2015-10-22 12:10:31]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-10-22 12:10:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1414903002/#ps120001
(title: "Fix lifetime bug between GrDrawTarget & GrRenderTarget in non-MDB
world")

[commit-bot: I haz the power, 2015-10-22 12:10:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/120001

[commit-bot: I haz the power, 2015-10-22 12:19:54]

Committed patchset #6 (id:120001) as
https://skia.googlesource.com/skia/+/869c5e82a725a6928a45cd1fa6945ac783b8b3d8

[robertphillips, 2015-10-22 12:31:19]

A revert of this CL (patchset #6 id:120001) has been created in
https://codereview.chromium.org/1417263002/ by robertphillips@google.com.

The reason for reverting is: Breaking bots.

[robertphillips, 2015-10-22 12:33:41]

Description was changed from

==========
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery
to GrDrawTarget to enable topological sorting)

BUG=skia:4094

Committed:
https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be

Committed:
https://skia.googlesource.com/skia/+/869c5e82a725a6928a45cd1fa6945ac783b8b3d8
==========

to

==========
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery
to GrDrawTarget to enable topological sorting)

BUG=skia:4094

Committed:
https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be

Committed:
https://skia.googlesource.com/skia/+/869c5e82a725a6928a45cd1fa6945ac783b8b3d8
==========

[robertphillips, 2015-10-30 16:51:44]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 16:51:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/160001

[commit-bot: I haz the power, 2015-10-30 17:03:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 17:03:08]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-30 17:10:46]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-10-30 17:10:47]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1414903002/#ps160001
(title: "Fix leak on abandon issue")

[commit-bot: I haz the power, 2015-10-30 17:10:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414903002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414903002/160001

[commit-bot: I haz the power, 2015-10-30 17:11:36]

Committed patchset #8 (id:160001) as
https://skia.googlesource.com/skia/+/498d7ac86bfb45bdfc8f9aa7424f7236235987b5