Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1414883010: Revert of Fix formatting specifier for MSVC++ 2013 compatibility. (Closed)

Created:
5 years, 1 month ago by tommycli
Modified:
5 years, 1 month ago
Reviewers:
miu, brucedawson
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix formatting specifier for MSVC++ 2013 compatibility. (patchset #1 id:1 of https://codereview.chromium.org/1411663012/ ) Reason for revert: Speculatively revert to try to fix this: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(DrMemory%20full)%20(2) The error message is very obtuse, but seems to indicate it's some kind of string formatting issue. Feel free to revert the revert if it doesn't fix the issue. Tommy Original issue's description: > Fix formatting specifier for MSVC++ 2013 compatibility. > > The use of %zu in a printf format string is non-standard. This change > is a follow-up to https://codereview.chromium.org/1417873007 to use the > standard PRIuS macro instead. > > BUG=519022 > TBR=brucedawson@chromium.org > > Committed: https://crrev.com/1dbefc62bf1df69475bea39c5a41f7825c72a6b0 > Cr-Commit-Position: refs/heads/master@{#357582} TBR=brucedawson@chromium.org,miu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=519022 Committed: https://crrev.com/2054dbed4e6ade0129716eeffdcd9f2e4b34fd1c Cr-Commit-Position: refs/heads/master@{#357956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M media/cast/sender/external_video_encoder.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tommycli
Created Revert of Fix formatting specifier for MSVC++ 2013 compatibility.
5 years, 1 month ago (2015-11-05 00:48:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414883010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414883010/1
5 years, 1 month ago (2015-11-05 00:50:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 00:53:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2054dbed4e6ade0129716eeffdcd9f2e4b34fd1c Cr-Commit-Position: refs/heads/master@{#357956}
5 years, 1 month ago (2015-11-05 00:54:18 UTC) #4
miu
Per off-line conversation, this wasn't the cause of the memory bot failures. Reverting the revert...
5 years, 1 month ago (2015-11-05 20:51:22 UTC) #5
miu
5 years, 1 month ago (2015-11-05 20:52:06 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1421463009/ by miu@chromium.org.

The reason for reverting is: Per off-line conversation, this wasn't the cause of
the memory bot failures.  Back into the tree you go!  :).

Powered by Google App Engine
This is Rietveld 408576698