Stop unwanted sharing between filter closures.

pkg/analysis_server/lib/src/context_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library context.directory.manager;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:core' hide Resource;
 
 import 'package:analysis_server/plugin/analysis/resolver_provider.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/instrumentation/instrumentation.dart';
 import 'package:analyzer/plugin/options.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
 import 'package:analyzer/source/package_map_provider.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
 import 'package:analyzer/source/path_filter.dart';
 import 'package:analyzer/source/pub_package_map_provider.dart';
 import 'package:analyzer/source/sdk_ext.dart';
 import 'package:analyzer/src/context/context.dart' as context;
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/java_engine.dart';
 import 'package:analyzer/src/generated/java_io.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
+import 'package:analyzer/src/task/options.dart';
 import 'package:package_config/packages.dart';
 import 'package:package_config/packages_file.dart' as pkgfile show parse;
 import 'package:package_config/src/packages_impl.dart' show MapPackages;
 import 'package:path/path.dart' as pathos;
 import 'package:watcher/watcher.dart';
 import 'package:yaml/yaml.dart';
 
 /**
  * Information tracked by the [ContextManager] for each context.
  */
@@ skipping 506 matching lines @@
 
     // Rebuild contexts based on the data last sent to setRoots().
     setRoots(includedPaths, excludedPaths, packageRoots);
   }
 
   void setFiltersForContext(ContextInfo info, YamlNode codes) {
     List<ErrorFilter> filters = <ErrorFilter>[];
     // If codes are enumerated, collect them as filters; else leave filters
     // empty to overwrite previous value.
     if (codes is YamlMap) {
-      String code, value;
+      String value;
       codes.nodes.forEach((k, v) {
         if (k is YamlScalar && v is YamlScalar) {
           value = v.value?.toString()?.toLowerCase();
-          if (value == 'false' || value == 'ignore') {
+          if (AnalyzerOptions.ignoreSynonyms.contains(value)) {
             // Case-insensitive.
-            code = k.value?.toString()?.toUpperCase();
+            String code = k.value?.toString()?.toUpperCase();
             filters.add((AnalysisError error) => error.errorCode.name == code);
           }
         }
       });
     }
     info.context.setConfigurationData(CONFIGURED_ERROR_FILTERS, filters);
   }
 
   /**
    * Sets the [ignorePatterns] for the context having info [info].
@@ skipping 897 matching lines @@
           var path = resourceProvider.pathContext.fromUri(uri);
           packageMap[name] = <Folder>[resourceProvider.getFolder(path)];
         }
       });
       return <UriResolver>[new SdkExtUriResolver(packageMap)];
     } else {
       return const <UriResolver>[];
     }
   }
 }