Chromium Code Reviews

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1414853003: Add options for audio/video autoplay to chrome://settings/content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index c1472ef6326c1de774ce5b1a7477b5b4e5dea705..e00b885b41a27a1bb88420be0232933f1b6277f5 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -356,6 +356,8 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName, Document& docum
if (document.settings() && document.settings()->mediaPlaybackRequiresUserGesture())
philipj_slow 2015/10/28 10:19:35 This is the "existing setting" I was referring to.
DaleCurtis 2015/10/30 19:25:56 Ah gotcha, yeah this should be removable once we h
philipj_slow 2015/11/02 13:15:45 If it isn't too much trouble, could you do it in t
m_userGestureRequiredForPlay = true;
+ if (!document.frame()->loader().allowMediaAutoplay(false))
philipj_slow 2015/10/23 09:06:14 Can document().frame() be null? It's usually null
+ m_userGestureRequiredForPlay = true;
setHasCustomStyleCallbacks();
addElementToDocumentMap(this, &document);

Powered by Google App Engine