Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: components/content_settings/core/browser/content_settings_registry.cc

Issue 1414853003: Add options for audio/video autoplay to chrome://settings/content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_registry.cc
diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc
index 28b46b6264db446c69041a228043857c1ee45a09..5febaebaee59b041bcaad0fc6422e22bb4054c91 100644
--- a/components/content_settings/core/browser/content_settings_registry.cc
+++ b/components/content_settings/core/browser/content_settings_registry.cc
@@ -228,6 +228,13 @@ void ContentSettingsRegistry::Init() {
WhitelistedSchemes(),
ValidSettings(CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK));
+ Register(CONTENT_SETTINGS_TYPE_MEDIA_AUTOPLAY, "media-autoplay",
+ CONTENT_SETTING_DETECT_IMPORTANT_CONTENT,
+ WebsiteSettingsInfo::SYNCABLE, WhitelistedSchemes(),
raymes 2015/10/27 23:34:51 Do we really want this setting sync'd across devic
DaleCurtis 2015/10/27 23:38:31 Hmm, possibly not since Android would default to C
felt 2015/10/28 07:52:45 My $0.02: the fact that there are different defaul
msramek 2015/10/28 10:42:50 Note that content settings are currently not synce
Bernhard Bauer 2015/10/28 12:52:58 It kind of sounds to me like what we want here is
+ ValidSettings(CONTENT_SETTING_ALLOW,
+ CONTENT_SETTING_DETECT_IMPORTANT_CONTENT,
+ CONTENT_SETTING_BLOCK));
+
// Content settings that aren't used to store any data. TODO(raymes): use a
// different mechanism rather than content settings to represent these.
// Since nothing is stored in them, there is no real point in them being a

Powered by Google App Engine
This is Rietveld 408576698