chrome/app/generated_resources.grd

Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index d453307eb03245193d5f3d3de93dbee7bc2af16e..0de5f6f8af4752f874457024e73cf6327c1c3776 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -333,6 +333,9 @@ are declared in build/common.gypi.
       <message name="IDS_WEBSITE_SETTINGS_TYPE_STORAGE" desc="The label used for the local storage type in the Manage Sites settings.">
         Storage
       </message>
+      <message name="IDS_WEBSITE_SETTINGS_TYPE_MEDIA_AUTOPLAY" desc="The label used for the media autoplay type in the Website Settings popup.">
+        Media Autoplay
+      </message>
       <message name="IDS_WEBSITE_SETTINGS_TAB_LABEL_CONNECTION" desc="The label of the connection tab of the Website Settings popup.">
         Connection
       </message>
@@ -14586,6 +14589,20 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
         </message>
       </if>
 
+      <!-- Media Autoplay messages -->
+      <message name="IDS_MEDIA_AUTOPLAY_TAB_LABEL" desc="The label used for the media autoplay section in the Content Settings dialog.">
+        Media Autoplay
+      </message>
+      <message name="IDS_MEDIA_AUTOPLAY_ALLOW_RADIO" desc="A radio button in the Content Settings dialog to allow autoplay of all audio or video content.">
+        Allow autoplay of all audio or video content

[msramek, 2015/10/28 10:42:50]

The wording should be "Allow all sites to autoplay...", "Ask if a site...", "Do
not allow any site..." as elsewhere. (I've now noticed that there are already
some inconsistencies, and some are my fault :/, but we probably shouldn't add
more)

+      </message>
+      <message name="IDS_MEDIA_AUTOPLAY_DETECT_RECOMMENDED_RADIO" desc="A radio button in the Content Settings dialog to only allow autoplay of audio or video content detected as important.">
+        Allow autoplay of only audio or video content detected as important (recommended)

[philipj_slow, 2015/10/23 12:17:30]

The description sounds like there's some non-trivial heuristic going on, but as
implemented it only checks if the tab is visible, I think. Is it described like
this because you plan to change this? It doesn't matter much in this CL, but I'm
rather worried about ever making some non-trivial heuristic the default, as that
seems rather hopeless to get interoperably implemented, and it's hard to explain
to web developers.

[DaleCurtis, 2015/10/23 19:21:27]

There are discussions to see if we can reuse some of the heuristics from the
plugin-power-saver for selectively allowing autoplay and then there's the
experiments work you mention. So I chose "detected as important" here to fit
into the existing landscape of CONTENT_SETTINGS_TYPE values, but also in the
case we want to expand the scope beyond what we use today on desktop and
Android.

[philipj_slow, 2015/10/28 10:30:40]

Perhaps this is a long way from shipping, but if it does initially ship with
only the requirement that media element's document is visible, then describing
it as "allow autoplay in foreground" or similar to the users seems to be more
understandable. However, this is ultimately a question for UI/UX. I would prefer
it to be accurate internally, however and doing a search/replace if it changes.

+      </message>
+      <message name="IDS_MEDIA_AUTOPLAY_BLOCK_RADIO" desc="A radio button in the Content Settings dialog to block autoplay of all audio or video content.">
+        Do not allow autoplay of any audio or video content
+      </message>
+
       <!-- Copresence settings/debug strings -->
       <if expr="not is_android and not is_ios">
         <message name="IDS_COPRESENCE_TITLE" desc="Title for the chrome://copresence page.">