Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1414843003: Image filters: Replace all use of tryAllocPixels() with createDevice(). (Closed)

Created:
5 years, 2 months ago by Stephen White
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Image filters: Replace all use of tryAllocPixels() with createDevice(). In order to have a central pinch point for bitmap allocation, change all filters to use Proxy::createDevice() instead of allocating memory directly with SkBitmap::tryAllocPixels(). This will aid in moving filter backing stores and caches to discardable memory. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1d3ff434954189e194c468f429598465146dcf4b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix morphology: don't allocate dest or temp until we need them #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -21 lines) Patch
M src/effects/SkAlphaThresholdFilter.cpp View 1 3 chunks +6 lines, -2 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 3 chunks +9 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 4 chunks +11 lines, -5 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mtklein
lgtm
5 years, 2 months ago (2015-10-20 16:24:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414843003/20001
5 years, 2 months ago (2015-10-20 16:24:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414843003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414843003/40001
5 years, 2 months ago (2015-10-20 16:32:07 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 16:49:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414843003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414843003/40001
5 years, 2 months ago (2015-10-20 17:16:49 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 17:17:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1d3ff434954189e194c468f429598465146dcf4b

Powered by Google App Engine
This is Rietveld 408576698