Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 141483011: add_codereview_message script to append messages to a CL (Closed)

Created:
6 years, 10 months ago by hal.canary
Modified:
6 years, 10 months ago
Reviewers:
borenet, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

add_codereview_message script to append messages to a CL Add add_codereview_message.py script. This script takes a message and a codereview URL as arguments calls `git cl upload` to append the message to the given codereview issue. Motivation: We are automating a process of testing Chromium/Skia DEPS rolls where roll_deps.py is automatically run every night, and then at a later time, compare_codereview.py is run to generate a report of the trybot results. This script can be used to append that report to the DEPS roll Cl. This CL also refactors functioanlity common to roll_deps and add_codereview_message: * Add tools/git_utils.py module. - ChangeGitBranch class was factored out of roll_deps.GitBranchCLUpload. The other half of that class became roll_deps.git_cl_uploader function. I make use of this new class in both roll_deps and upload_deps_roll. - test_git_executable moved to this new module. * Add tools/misc_utils.py - move VerboseSubprocess, ChangeDir, and ReSearch classes from roll_deps module. * Remove generic functions from roll_deps. * Add git_cl_uploader function to roll_deps. Refactor roll_deps.roll_deps function to make use of it BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13251

Patch Set 1 #

Patch Set 2 : linting #

Total comments: 16

Patch Set 3 : lots of changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+642 lines, -388 lines) Patch
A tools/add_codereview_message.py View 1 2 1 chunk +148 lines, -0 lines 0 comments Download
A tools/git_utils.py View 1 2 1 chunk +168 lines, -0 lines 0 comments Download
A tools/misc_utils.py View 1 2 1 chunk +224 lines, -0 lines 0 comments Download
M tools/roll_deps.py View 1 2 15 chunks +102 lines, -388 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hal.canary
Rob, here's the script you asked for last week. Please make sure it works for ...
6 years, 10 months ago (2014-01-29 17:04:30 UTC) #1
robertphillips
Sorry - I forgot to use this last night and just used the auto-roll-bot's results. ...
6 years, 10 months ago (2014-01-30 14:04:40 UTC) #2
borenet
https://codereview.chromium.org/141483011/diff/20001/tools/add_codereview_message.py File tools/add_codereview_message.py (right): https://codereview.chromium.org/141483011/diff/20001/tools/add_codereview_message.py#newcode43 tools/add_codereview_message.py:43: """Function that does the meat of the work. This ...
6 years, 10 months ago (2014-01-30 14:36:35 UTC) #3
hal.canary
https://codereview.chromium.org/141483011/diff/20001/tools/add_codereview_message.py File tools/add_codereview_message.py (right): https://codereview.chromium.org/141483011/diff/20001/tools/add_codereview_message.py#newcode43 tools/add_codereview_message.py:43: """Function that does the meat of the work. On ...
6 years, 10 months ago (2014-01-30 20:11:02 UTC) #4
borenet
LGTM. Thanks for the fixes.
6 years, 10 months ago (2014-01-30 21:25:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/141483011/40001
6 years, 10 months ago (2014-01-30 21:26:46 UTC) #6
commit-bot: I haz the power
Change committed as 13251
6 years, 10 months ago (2014-01-30 22:12:35 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 22:13:19 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698