Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 141483005: Add polymer-selector and polymer-selection to polymer. (Closed)

Created:
6 years, 11 months ago by raymes
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add polymer-selector and polymer-selection to polymer. These polymer UI components are needed for the PDF extension. BUG=303491 R=bshe@chromium.org, koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246216 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246514

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1081 lines, --5 lines) Patch
M third_party/polymer/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/polymer/bower.json View 1 1 chunk +3 lines, -1 line 0 comments Download
A third_party/polymer/polymer-selection/.bower.json View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/polymer/polymer-selection/AUTHORS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/polymer-selection/CONTRIBUTING.md View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/polymer/polymer-selection/LICENSE View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/polymer-selection/PATENTS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/polymer-selection/bower.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selection/index.html View 1 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selection/polymer-selection.html View 1 1 chunk +153 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selection/test/html/polymer-selection.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selection/test/html/polymer-selection-multi.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selection/test/js/polymer-selection.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selection/test/runner.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/.bower.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/polymer/polymer-selector/AUTHORS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/polymer-selector/CONTRIBUTING.md View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/polymer/polymer-selector/LICENSE View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/polymer-selector/PATENTS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/polymer-selector/README.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/bower.json View 1 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/index.html View 1 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/polymer-selector.html View 1 1 chunk +354 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/test/html/polymer-selector-activate-event.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/test/html/polymer-selector-basic.html View 1 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/test/html/polymer-selector-multi.html View 1 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/test/js/polymer-selector.js View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/polymer/polymer-selector/test/runner.html View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
raymes
6 years, 11 months ago (2014-01-21 07:18:52 UTC) #1
bshe
On 2014/01/21 07:18:52, raymes wrote: lgtm It may conflict with this CL: https://codereview.chromium.org/137393003/
6 years, 11 months ago (2014-01-21 15:30:56 UTC) #2
bshe
On 2014/01/21 15:30:56, bshe wrote: > On 2014/01/21 07:18:52, raymes wrote: > > lgtm > ...
6 years, 11 months ago (2014-01-21 15:34:08 UTC) #3
koz (OOO until 15th September)
lgtm
6 years, 11 months ago (2014-01-21 22:12:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/141483005/1
6 years, 11 months ago (2014-01-21 22:56:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=192980
6 years, 11 months ago (2014-01-22 00:35:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/141483005/1
6 years, 11 months ago (2014-01-22 01:04:50 UTC) #7
raymes
Committed patchset #1 manually as r246216 (presubmit successful).
6 years, 11 months ago (2014-01-22 02:45:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/141483005/770002
6 years, 11 months ago (2014-01-22 23:57:00 UTC) #9
raymes
6 years, 11 months ago (2014-01-23 03:44:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r246514 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698