Issue 14148004: [Autofill] Move IsValidState() into validation.h

Issue 14148004: [Autofill] Move IsValidState() into validation.h (Closed)

Created:
7 years, 8 months ago by Ilya Sherman

Modified:
7 years, 8 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Autofill] Move IsValidState() into validation.h BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194497

Patch Set 1 #

Total comments: 4

Patch Set 2 : Don't rely on a magic constant #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -111 lines)			Patch
M	components/autofill.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/autofill/browser/form_group.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	components/autofill/browser/form_group.cc	View	1	4 chunks	+9 lines, -102 lines	0 comments	Download
M	components/autofill/browser/personal_data_manager.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
A	components/autofill/browser/state_names.h	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	components/autofill/browser/state_names.cc	View		1 chunk	+99 lines, -0 lines	0 comments	Download
M	components/autofill/browser/validation.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	components/autofill/browser/validation.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

https://chromiumcodereview.appspot.com/14148004/diff/1/components/autofill/browser/form_group.cc File components/autofill/browser/form_group.cc (left): https://chromiumcodereview.appspot.com/14148004/diff/1/components/autofill/browser/form_group.cc#oldcode144 components/autofill/browser/form_group.cc:144: base::string16 abbrev, full; is there a rule against this ...

7 years, 8 months ago (2013-04-15 18:55:33 UTC) #2

Ilya Sherman

7 years, 8 months ago (2013-04-16 01:12:25 UTC) #3

Ilya Sherman

7 years, 8 months ago (2013-04-17 00:23:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r194497 (presubmit successful).

Expand Messages | Collapse Messages