Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1414793014: [ios] UMA metric to report cache miss for WKWebView cert verification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added entry to histograms.xml Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_wk_web_view_web_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 42330e5e123a21c856080f82647b4c8755e620c8..9056c17752e72c6bb97b3fb6b8152b0d170426ca 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -50611,6 +50611,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="WebController.CertVerificationErrorsCacheHit"
+ enum="BooleanSuccess">
Ilya Sherman 2015/11/05 21:31:13 Please define an enum with custom labels for this
Eugene But (OOO till 7-30) 2015/11/05 21:35:07 What is the advantage of a custom enum? "BooleanSu
Ilya Sherman 2015/11/05 21:42:01 "Hit" vs. "Miss" is much clearer than "Success" vs
Eugene But (OOO till 7-30) 2015/11/05 21:55:30 Sure. Done.
+ <owner>eugenebut@chromium.org</owner>
+ <summary>
+ [iOS] Report cache hit/miss for WKWebView cert verification. WKWebView Web
+ Controller has a cache of pending cert verification results to avoid extra
+ verifications when presenting SSL interstitial. This metric helps to
+ understand whether or not cache miss is possible.
+ </summary>
+</histogram>
+
<histogram name="WebController.ExternalURLRequestBlocking"
enum="IOSExternalURLRequestStatus">
<owner>jyquinn@chromium.org</owner>
« no previous file with comments | « ios/web/web_state/ui/crw_wk_web_view_web_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698