Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: base/threading/sequenced_worker_pool_unittest.cc

Issue 1414793009: Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: x Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/sequenced_worker_pool.h" 5 #include "base/threading/sequenced_worker_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 // Should be fine to call on an idle instance with all threads created, and 897 // Should be fine to call on an idle instance with all threads created, and
898 // spamming the method shouldn't deadlock or confuse the class. 898 // spamming the method shouldn't deadlock or confuse the class.
899 pool()->FlushForTesting(); 899 pool()->FlushForTesting();
900 pool()->FlushForTesting(); 900 pool()->FlushForTesting();
901 901
902 // Should be fine to call after shutdown too. 902 // Should be fine to call after shutdown too.
903 pool()->Shutdown(); 903 pool()->Shutdown();
904 pool()->FlushForTesting(); 904 pool()->FlushForTesting();
905 } 905 }
906 906
907 namespace {
908
909 void CheckWorkerPoolAndSequenceToken(
910 const scoped_refptr<SequencedWorkerPool>& expected_pool,
911 SequencedWorkerPool::SequenceToken expected_token) {
912 SequencedWorkerPool::SequenceToken token =
913 SequencedWorkerPool::GetSequenceTokenForCurrentThread();
914 EXPECT_EQ(expected_token.ToString(), token.ToString());
915
916 scoped_refptr<SequencedWorkerPool> pool =
917 SequencedWorkerPool::GetWorkerPoolForCurrentThread();
918 EXPECT_EQ(expected_pool, pool);
919 }
920
921 } // namespace
922
923 TEST_F(SequencedWorkerPoolTest, GetWorkerPoolAndSequenceTokenForCurrentThread) {
924 EnsureAllWorkersCreated();
925
926 // The current thread should have neither a worker pool nor a sequence token.
927 SequencedWorkerPool::SequenceToken local_token =
928 SequencedWorkerPool::GetSequenceTokenForCurrentThread();
929 scoped_refptr<SequencedWorkerPool> local_pool =
930 SequencedWorkerPool::GetWorkerPoolForCurrentThread();
931 EXPECT_FALSE(local_token.IsValid()) << local_token.ToString();
932 EXPECT_FALSE(local_pool);
933
934 SequencedWorkerPool::SequenceToken token1 = pool()->GetSequenceToken();
935 SequencedWorkerPool::SequenceToken token2 = pool()->GetSequenceToken();
936 pool()->PostSequencedWorkerTask(
937 token1, FROM_HERE,
938 base::Bind(&CheckWorkerPoolAndSequenceToken, pool(), token1));
939 pool()->PostSequencedWorkerTask(
940 token2, FROM_HERE,
941 base::Bind(&CheckWorkerPoolAndSequenceToken, pool(), token2));
942
943 pool()->PostWorkerTask(FROM_HERE,
944 base::Bind(&CheckWorkerPoolAndSequenceToken, pool(),
945 SequencedWorkerPool::SequenceToken()));
946
947 pool()->FlushForTesting();
948 }
949
950 TEST(SequencedWorkerPoolRefPtrTest, ShutsDownCleanWithContinueOnShutdown) { 907 TEST(SequencedWorkerPoolRefPtrTest, ShutsDownCleanWithContinueOnShutdown) {
951 MessageLoop loop; 908 MessageLoop loop;
952 scoped_refptr<SequencedWorkerPool> pool(new SequencedWorkerPool(3, "Pool")); 909 scoped_refptr<SequencedWorkerPool> pool(new SequencedWorkerPool(3, "Pool"));
953 scoped_refptr<SequencedTaskRunner> task_runner = 910 scoped_refptr<SequencedTaskRunner> task_runner =
954 pool->GetSequencedTaskRunnerWithShutdownBehavior( 911 pool->GetSequencedTaskRunnerWithShutdownBehavior(
955 pool->GetSequenceToken(), 912 pool->GetSequenceToken(),
956 base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN); 913 base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
957 914
958 // Upon test exit, should shut down without hanging. 915 // Upon test exit, should shut down without hanging.
959 pool->Shutdown(); 916 pool->Shutdown();
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1078 SequencedWorkerPoolSequencedTaskRunner, SequencedTaskRunnerTest, 1035 SequencedWorkerPoolSequencedTaskRunner, SequencedTaskRunnerTest,
1079 SequencedWorkerPoolSequencedTaskRunnerTestDelegate); 1036 SequencedWorkerPoolSequencedTaskRunnerTestDelegate);
1080 INSTANTIATE_TYPED_TEST_CASE_P( 1037 INSTANTIATE_TYPED_TEST_CASE_P(
1081 SequencedWorkerPoolSequencedTaskRunner, 1038 SequencedWorkerPoolSequencedTaskRunner,
1082 SequencedTaskRunnerDelayedTest, 1039 SequencedTaskRunnerDelayedTest,
1083 SequencedWorkerPoolSequencedTaskRunnerTestDelegate); 1040 SequencedWorkerPoolSequencedTaskRunnerTestDelegate);
1084 1041
1085 } // namespace 1042 } // namespace
1086 1043
1087 } // namespace base 1044 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698