Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414793003: Fix PathUtilsTest.TestGetNativeLibraryDirectory on GN (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PathUtilsTest.TestGetNativeLibraryDirectory on GN BUG=510485 TEST=None Committed: https://crrev.com/5f2455e879be88c38ca1f7cd88588ef14c20cbb6 Cr-Commit-Position: refs/heads/master@{#355301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/android/path_utils_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pkotwicz
yfriedman@ can you please take a look?
5 years, 2 months ago (2015-10-20 01:02:24 UTC) #2
pkotwicz
Yaron, Ping!
5 years, 2 months ago (2015-10-21 14:25:49 UTC) #5
Yaron
lgtm - not sure how i missed this sorry
5 years, 2 months ago (2015-10-21 14:32:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414793003/1
5 years, 2 months ago (2015-10-21 15:26:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 15:40:44 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 15:41:34 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5f2455e879be88c38ca1f7cd88588ef14c20cbb6
Cr-Commit-Position: refs/heads/master@{#355301}

Powered by Google App Engine
This is Rietveld 408576698