Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: media/capture/webm_muxer.cc

Issue 1414793002: Update WebmMuxer for audio component of MediaStream recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/capture/webm_muxer.h" 5 #include "media/capture/webm_muxer.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "media/audio/audio_parameters.h"
8 #include "media/base/limits.h" 9 #include "media/base/limits.h"
9 #include "media/base/video_frame.h" 10 #include "media/base/video_frame.h"
11 #include "media/filters/opus_constants.h"
10 #include "ui/gfx/geometry/size.h" 12 #include "ui/gfx/geometry/size.h"
11 13
12 namespace media { 14 namespace media {
13 15
16 namespace {
17
18 void WriteOpusHeader(const media::AudioParameters& params, uint8* header) {
19 // See https://wiki.xiph.org/OggOpus#ID_Header.
20 // Set magic signature.
21 std::string label = "OpusHead";
22 memcpy(header + OPUS_EXTRADATA_LABEL_OFFSET, &label, label.size());
23 // Set Opus version.
24 header[OPUS_EXTRADATA_VERSION_OFFSET] = 1;
25 // Set channel count.
26 header[OPUS_EXTRADATA_CHANNELS_OFFSET] = params.channels();
27 // Set pre-skip
28 uint16 skip = 0;
29 memcpy(header + OPUS_EXTRADATA_SKIP_SAMPLES_OFFSET, &skip, sizeof(uint16));
30 // Set original input sample rate in Hz.
31 uint32 sample_rate = params.sample_rate();
32 memcpy(header + OPUS_EXTRADATA_SAMPLE_RATE_OFFSET, &sample_rate,
33 sizeof(uint32));
34 // Set output gain in dB.
35 uint16 gain = 0;
36 memcpy(header + OPUS_EXTRADATA_GAIN_OFFSET, &gain, 2);
37
38 // Set channel mapping.
39 if (params.channels() > 2) {
40 // Also possible to have a multistream, not supported for now.
41 DCHECK_LE(params.channels(), OPUS_MAX_VORBIS_CHANNELS);
42 header[OPUS_EXTRADATA_CHANNEL_MAPPING_OFFSET] = 1;
43 // Assuming no coupled streams. This should actually be
44 // channels() - |coupled_streams|.
45 header[OPUS_EXTRADATA_NUM_STREAMS_OFFSET] = params.channels();
46 header[OPUS_EXTRADATA_NUM_COUPLED_OFFSET] = 0;
47 // Set the actual stream map.
48 memcpy(header + OPUS_EXTRADATA_STREAM_MAP_OFFSET,
49 kOpusVorbisChannelMap[params.channels() - 1], params.channels());
50 } else {
51 header[OPUS_EXTRADATA_CHANNEL_MAPPING_OFFSET] = 0;
52 }
53 }
54
14 static double GetFrameRate(const scoped_refptr<VideoFrame>& video_frame) { 55 static double GetFrameRate(const scoped_refptr<VideoFrame>& video_frame) {
15 const double kZeroFrameRate = 0.0; 56 const double kZeroFrameRate = 0.0;
16 const double kDefaultFrameRate = 30.0; 57 const double kDefaultFrameRate = 30.0;
17 58
18 double frame_rate = kDefaultFrameRate; 59 double frame_rate = kDefaultFrameRate;
19 if (!video_frame->metadata()->GetDouble( 60 if (!video_frame->metadata()->GetDouble(
20 VideoFrameMetadata::FRAME_RATE, &frame_rate) || 61 VideoFrameMetadata::FRAME_RATE, &frame_rate) ||
21 frame_rate <= kZeroFrameRate || 62 frame_rate <= kZeroFrameRate ||
22 frame_rate > media::limits::kMaxFramesPerSecond) { 63 frame_rate > media::limits::kMaxFramesPerSecond) {
23 frame_rate = kDefaultFrameRate; 64 frame_rate = kDefaultFrameRate;
24 } 65 }
25 return frame_rate; 66 return frame_rate;
26 } 67 }
27 68
28 WebmMuxer::WebmMuxer(VideoCodec codec, const WriteDataCB& write_data_callback) 69 } // anonymous namespace
70
71 WebmMuxer::WebmMuxer(VideoCodec codec,
72 uint8_t num_video_tracks,
73 uint8_t num_audio_tracks,
74 const WriteDataCB& write_data_callback)
29 : use_vp9_(codec == kCodecVP9), 75 : use_vp9_(codec == kCodecVP9),
30 track_index_(0), 76 video_track_index_(0),
77 audio_track_index_(0),
78 num_video_tracks_(num_video_tracks),
79 num_audio_tracks_(num_audio_tracks),
31 write_data_callback_(write_data_callback), 80 write_data_callback_(write_data_callback),
32 position_(0) { 81 position_(0) {
82 // The max track number in libwebm is 126. Add{Audio|Video}Track will fail
83 // if track number exceeds this value. See
84 // https://chromium.googlesource.com/webm/libwebm/+/master/mkvmuxer.hpp
85 DCHECK_LT(num_video_tracks, mkvmuxer::kMaxTrackNumber);
86 DCHECK_LT(num_audio_tracks, mkvmuxer::kMaxTrackNumber);
87 DCHECK(num_video_tracks > 0 || num_audio_tracks > 0);
88 // For now, we support a maximum of one of each kind of track.
89 // http://crbug.com/528523
90 DCHECK(num_video_tracks <= 1 && num_audio_tracks <= 1);
33 DCHECK(!write_data_callback_.is_null()); 91 DCHECK(!write_data_callback_.is_null());
34 DCHECK(codec == kCodecVP8 || codec == kCodecVP9) 92 DCHECK(codec == kCodecVP8 || codec == kCodecVP9)
35 << " Only Vp8 and VP9 are supported in WebmMuxer"; 93 << " Only Vp8 and VP9 are supported in WebmMuxer";
94
95 segment_.Init(this);
96 segment_.set_mode(mkvmuxer::Segment::kLive);
97 segment_.OutputCues(false);
98
99 mkvmuxer::SegmentInfo* const info = segment_.GetSegmentInfo();
100 info->set_writing_app("Chrome");
101 info->set_muxing_app("Chrome");
102
36 // Creation is done on a different thread than main activities. 103 // Creation is done on a different thread than main activities.
37 thread_checker_.DetachFromThread(); 104 thread_checker_.DetachFromThread();
38 } 105 }
39 106
40 WebmMuxer::~WebmMuxer() { 107 WebmMuxer::~WebmMuxer() {
41 // No need to segment_.Finalize() since is not Seekable(), i.e. a live 108 // No need to segment_.Finalize() since is not Seekable(), i.e. a live
42 // stream, but is a good practice. 109 // stream, but is a good practice.
43 DCHECK(thread_checker_.CalledOnValidThread()); 110 DCHECK(thread_checker_.CalledOnValidThread());
44 segment_.Finalize(); 111 segment_.Finalize();
45 } 112 }
46 113
47 void WebmMuxer::OnEncodedVideo(const scoped_refptr<VideoFrame>& video_frame, 114 void WebmMuxer::OnEncodedVideo(const scoped_refptr<VideoFrame>& video_frame,
48 scoped_ptr<std::string> encoded_data, 115 scoped_ptr<std::string> encoded_data,
49 base::TimeTicks timestamp, 116 base::TimeTicks timestamp,
50 bool is_key_frame) { 117 bool is_key_frame) {
51 DVLOG(1) << __FUNCTION__ << " - " << encoded_data->size() << "B"; 118 DVLOG(1) << __FUNCTION__ << " - " << encoded_data->size() << "B";
52 DCHECK(thread_checker_.CalledOnValidThread()); 119 DCHECK(thread_checker_.CalledOnValidThread());
53 if (!track_index_) { 120
121 if (!video_track_index_) {
54 // |track_index_|, cannot be zero (!), initialize WebmMuxer in that case. 122 // |track_index_|, cannot be zero (!), initialize WebmMuxer in that case.
55 // http://www.matroska.org/technical/specs/index.html#Tracks 123 // http://www.matroska.org/technical/specs/index.html#Tracks
56 AddVideoTrack(video_frame->visible_rect().size(), 124 AddVideoTrack(video_frame->visible_rect().size(),
57 GetFrameRate(video_frame)); 125 GetFrameRate(video_frame));
58 first_frame_timestamp_ = timestamp; 126 if (first_frame_timestamp_.is_null())
127 first_frame_timestamp_ = timestamp;
59 } 128 }
129
130 // TODO(ajose): Don't drop data. http://crbug.com/547948
131 // TODO(ajose): Update this when we support multiple tracks.
132 // http://crbug.com/528523
133 if (num_audio_tracks_ > 0 && !audio_track_index_) {
134 DVLOG(1) << __FUNCTION__ << ": delaying until audio track ready.";
135 return;
136 }
137
138 most_recent_timestamp_ =
139 std::max(most_recent_timestamp_, timestamp - first_frame_timestamp_);
60 segment_.AddFrame(reinterpret_cast<const uint8_t*>(encoded_data->data()), 140 segment_.AddFrame(reinterpret_cast<const uint8_t*>(encoded_data->data()),
61 encoded_data->size(), 141 encoded_data->size(), video_track_index_,
62 track_index_, 142 most_recent_timestamp_.InMicroseconds() *
63 (timestamp - first_frame_timestamp_).InMicroseconds() *
64 base::Time::kNanosecondsPerMicrosecond, 143 base::Time::kNanosecondsPerMicrosecond,
65 is_key_frame); 144 is_key_frame);
66 } 145 }
67 146
147 void WebmMuxer::OnEncodedAudio(const media::AudioParameters& params,
148 scoped_ptr<std::string> encoded_data,
149 base::TimeTicks timestamp) {
150 DVLOG(1) << __FUNCTION__ << " - " << encoded_data->size() << "B";
151 DCHECK(thread_checker_.CalledOnValidThread());
152
153 if (!audio_track_index_) {
154 AddAudioTrack(params);
155 if (first_frame_timestamp_.is_null())
156 first_frame_timestamp_ = timestamp;
157 }
158
159 // TODO(ajose): Don't drop data. http://crbug.com/547948
160 // TODO(ajose): Update this when we support multiple tracks.
161 // http://crbug.com/528523
162 if (num_video_tracks_ > 0 && !video_track_index_) {
163 DVLOG(1) << __FUNCTION__ << ": delaying until video track ready.";
164 return;
165 }
166
167 most_recent_timestamp_ =
168 std::max(most_recent_timestamp_, timestamp - first_frame_timestamp_);
169 segment_.AddFrame(reinterpret_cast<const uint8_t*>(encoded_data->data()),
170 encoded_data->size(), audio_track_index_,
171 most_recent_timestamp_.InMicroseconds() *
172 base::Time::kNanosecondsPerMicrosecond,
173 true /* is_key_frame -- always true for audio */);
174 }
175
68 void WebmMuxer::AddVideoTrack(const gfx::Size& frame_size, double frame_rate) { 176 void WebmMuxer::AddVideoTrack(const gfx::Size& frame_size, double frame_rate) {
69 DCHECK(thread_checker_.CalledOnValidThread()); 177 DCHECK(thread_checker_.CalledOnValidThread());
70 DCHECK_EQ(track_index_, 0u) << "WebmMuxer can only be initialised once."; 178 DCHECK_LE(video_track_index_, num_video_tracks_);
179 DCHECK_EQ(0u, video_track_index_)
180 << "WebmMuxer can only be initialized once.";
71 181
72 segment_.Init(this); 182 video_track_index_ =
73 segment_.set_mode(mkvmuxer::Segment::kLive);
74 segment_.OutputCues(false);
75
76 mkvmuxer::SegmentInfo* const info = segment_.GetSegmentInfo();
77 info->set_writing_app("Chrome");
78 info->set_muxing_app("Chrome");
79
80 track_index_ =
81 segment_.AddVideoTrack(frame_size.width(), frame_size.height(), 0); 183 segment_.AddVideoTrack(frame_size.width(), frame_size.height(), 0);
82 DCHECK_GT(track_index_, 0u); 184 DCHECK_GT(video_track_index_, 0u);
83 185
84 mkvmuxer::VideoTrack* const video_track = 186 mkvmuxer::VideoTrack* const video_track =
85 reinterpret_cast<mkvmuxer::VideoTrack*>( 187 reinterpret_cast<mkvmuxer::VideoTrack*>(
86 segment_.GetTrackByNumber(track_index_)); 188 segment_.GetTrackByNumber(video_track_index_));
87 DCHECK(video_track); 189 DCHECK(video_track);
88 video_track->set_codec_id(use_vp9_ ? mkvmuxer::Tracks::kVp9CodecId 190 video_track->set_codec_id(use_vp9_ ? mkvmuxer::Tracks::kVp9CodecId
89 : mkvmuxer::Tracks::kVp8CodecId); 191 : mkvmuxer::Tracks::kVp8CodecId);
90 DCHECK_EQ(video_track->crop_right(), 0ull); 192 DCHECK_EQ(0ull, video_track->crop_right());
91 DCHECK_EQ(video_track->crop_left(), 0ull); 193 DCHECK_EQ(0ull, video_track->crop_left());
92 DCHECK_EQ(video_track->crop_top(), 0ull); 194 DCHECK_EQ(0ull, video_track->crop_top());
93 DCHECK_EQ(video_track->crop_bottom(), 0ull); 195 DCHECK_EQ(0ull, video_track->crop_bottom());
94 196
95 video_track->set_frame_rate(frame_rate); 197 video_track->set_frame_rate(frame_rate);
96 video_track->set_default_duration(base::Time::kNanosecondsPerSecond / 198 video_track->set_default_duration(base::Time::kNanosecondsPerSecond /
97 frame_rate); 199 frame_rate);
98 // Segment's timestamps should be in milliseconds, DCHECK it. See 200 // Segment's timestamps should be in milliseconds, DCHECK it. See
99 // http://www.webmproject.org/docs/container/#muxer-guidelines 201 // http://www.webmproject.org/docs/container/#muxer-guidelines
100 DCHECK_EQ(segment_.GetSegmentInfo()->timecode_scale(), 1000000ull); 202 DCHECK_EQ(1000000ull, segment_.GetSegmentInfo()->timecode_scale());
203 }
204
205 void WebmMuxer::AddAudioTrack(const media::AudioParameters& params) {
206 DCHECK(thread_checker_.CalledOnValidThread());
207 DCHECK_LE(audio_track_index_, num_audio_tracks_);
208 DCHECK_EQ(0u, audio_track_index_)
209 << "WebmMuxer audio can only be initialised once.";
210
211 audio_track_index_ =
212 segment_.AddAudioTrack(params.sample_rate(), params.channels(), 0);
213 DCHECK_GT(audio_track_index_, 0u);
214
215 mkvmuxer::AudioTrack* const audio_track =
216 reinterpret_cast<mkvmuxer::AudioTrack*>(
217 segment_.GetTrackByNumber(audio_track_index_));
218 DCHECK(audio_track);
219 audio_track->set_codec_id(mkvmuxer::Tracks::kOpusCodecId);
220
221 DCHECK_EQ(params.sample_rate(), audio_track->sample_rate());
222 DCHECK_EQ(params.channels(), static_cast<int>(audio_track->channels()));
223
224 uint8 opus_header[OPUS_EXTRADATA_SIZE];
225 WriteOpusHeader(params, opus_header);
226
227 if (!audio_track->SetCodecPrivate(opus_header, OPUS_EXTRADATA_SIZE))
228 LOG(ERROR) << __FUNCTION__ << ": failed to set opus header.";
229
230 // Segment's timestamps should be in milliseconds, DCHECK it. See
231 // http://www.webmproject.org/docs/container/#muxer-guidelines
232 DCHECK_EQ(1000000ull, segment_.GetSegmentInfo()->timecode_scale());
101 } 233 }
102 234
103 mkvmuxer::int32 WebmMuxer::Write(const void* buf, mkvmuxer::uint32 len) { 235 mkvmuxer::int32 WebmMuxer::Write(const void* buf, mkvmuxer::uint32 len) {
104 DCHECK(thread_checker_.CalledOnValidThread()); 236 DCHECK(thread_checker_.CalledOnValidThread());
105 DCHECK(buf); 237 DCHECK(buf);
106 write_data_callback_.Run( 238 write_data_callback_.Run(
107 base::StringPiece(reinterpret_cast<const char*>(buf), len)); 239 base::StringPiece(reinterpret_cast<const char*>(buf), len));
108 position_ += len; 240 position_ += len;
109 return 0; 241 return 0;
110 } 242 }
(...skipping 12 matching lines...) Expand all
123 } 255 }
124 256
125 void WebmMuxer::ElementStartNotify(mkvmuxer::uint64 element_id, 257 void WebmMuxer::ElementStartNotify(mkvmuxer::uint64 element_id,
126 mkvmuxer::int64 position) { 258 mkvmuxer::int64 position) {
127 // This method gets pinged before items are sent to |write_data_callback_|. 259 // This method gets pinged before items are sent to |write_data_callback_|.
128 DCHECK_GE(position, position_.ValueOrDefault(0)) 260 DCHECK_GE(position, position_.ValueOrDefault(0))
129 << "Can't go back in a live WebM stream."; 261 << "Can't go back in a live WebM stream.";
130 } 262 }
131 263
132 } // namespace media 264 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698