Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1414763004: [test] Make cfi more verbose. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make cfi more verbose. Set "no recover" in diagnostic mode to keep triggering crashes. Otherwise, the v8 test driver won't notice tests as failing. Also port some common sanitizer cflags to cfi - those can be removed on the build side afterwards. BUG=chromium:515782 LOG=n Committed: https://crrev.com/d6ebeb4e0d00d4f259ed48128ee1351775379a1c Cr-Commit-Position: refs/heads/master@{#31442}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/standalone.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Michael Achenbach
PTAL
5 years, 2 months ago (2015-10-21 08:21:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414763004/20001
5 years, 2 months ago (2015-10-21 08:22:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 08:49:40 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-21 13:21:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414763004/20001
5 years, 2 months ago (2015-10-21 13:30:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414763004/20001
5 years, 2 months ago (2015-10-21 13:34:08 UTC) #14
Alexander Potapenko
LGTM
5 years, 2 months ago (2015-10-21 13:34:54 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 13:35:26 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 13:35:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6ebeb4e0d00d4f259ed48128ee1351775379a1c
Cr-Commit-Position: refs/heads/master@{#31442}

Powered by Google App Engine
This is Rietveld 408576698