|
|
Created:
5 years, 2 months ago by Michael Achenbach Modified:
5 years, 2 months ago Reviewers:
Alexander Potapenko, jochen (gone - plz use gerrit) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Make cfi more verbose.
Set "no recover" in diagnostic mode to keep triggering
crashes. Otherwise, the v8 test driver won't notice tests
as failing.
Also port some common sanitizer cflags to cfi - those can be
removed on the build side afterwards.
BUG=chromium:515782
LOG=n
Committed: https://crrev.com/d6ebeb4e0d00d4f259ed48128ee1351775379a1c
Cr-Commit-Position: refs/heads/master@{#31442}
Patch Set 1 #Patch Set 2 : #
Created: 5 years, 2 months ago
Messages
Total messages: 17 (8 generated)
Description was changed from ========== [test] Make cfi more verbose. BUG= ========== to ========== [test] Make cfi more verbose. Set "no recover" in diagnostic mode to keep triggering crashes. Otherwise, the v8 test driver won't notice tests as failing. Also port some common sanitizer cflags to cfi - those can be removed on the build side afterwards. ==========
machenbach@chromium.org changed reviewers: + glider@chromium.org, jochen@chromium.org
Description was changed from ========== [test] Make cfi more verbose. Set "no recover" in diagnostic mode to keep triggering crashes. Otherwise, the v8 test driver won't notice tests as failing. Also port some common sanitizer cflags to cfi - those can be removed on the build side afterwards. ========== to ========== [test] Make cfi more verbose. Set "no recover" in diagnostic mode to keep triggering crashes. Otherwise, the v8 test driver won't notice tests as failing. Also port some common sanitizer cflags to cfi - those can be removed on the build side afterwards. BUG=chromium:515782 LOG=n ==========
PTAL
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414763004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414763004/20001
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414763004/20001
LGTM
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d6ebeb4e0d00d4f259ed48128ee1351775379a1c Cr-Commit-Position: refs/heads/master@{#31442} |