Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1414743005: Revert of [turbofan] Fix and enable property stores. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Fix and enable property stores. (patchset #2 id:20001 of https://codereview.chromium.org/1424523002/ ) Reason for revert: [Sheriff] Breaks benchmarks: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%20avx2/builds/3164 Original issue's description: > [turbofan] Fix and enable property stores. > > Fix lookup for storing to properties, and also make sure we don't embed > deprecated map (using Map::TryUpdate). > > R=jarin@chromium.org > BUG=v8:4470 > LOG=n > > Committed: https://crrev.com/70158828b3db8e582344272c6c11a957f4d8b2c8 > Cr-Commit-Position: refs/heads/master@{#31509} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470 Committed: https://crrev.com/50e5a7275f2bc93a8ae731acda0f7ac6e5e97c3c Cr-Commit-Position: refs/heads/master@{#31513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M src/compiler/js-native-context-specialization.cc View 6 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [turbofan] Fix and enable property stores.
5 years, 2 months ago (2015-10-23 11:15:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414743005/1
5 years, 2 months ago (2015-10-23 11:15:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 11:15:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50e5a7275f2bc93a8ae731acda0f7ac6e5e97c3c Cr-Commit-Position: refs/heads/master@{#31513}
5 years, 2 months ago (2015-10-23 11:16:12 UTC) #4
Benedikt Meurer
5 years, 2 months ago (2015-10-23 11:17:21 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1421573003/ by bmeurer@chromium.org.

The reason for reverting is: It is fixed..

Powered by Google App Engine
This is Rietveld 408576698