Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414733007: Stop creating static GrProcessor instances (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414733007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414733007/1
5 years, 2 months ago (2015-10-20 22:03:27 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-20 22:03:27 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 2 months ago (2015-10-21 04:03:04 UTC) #5
joshualitt
lgtm, state = static
5 years, 2 months ago (2015-10-21 13:27:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414733007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414733007/1
5 years, 2 months ago (2015-10-21 13:56:55 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 13:57:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/02141734f2f89fa4e89ba804bc06fa80ed0fc316

Powered by Google App Engine
This is Rietveld 408576698