Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analyzer/lib/src/task/html_work_manager.dart

Issue 1414733006: Issue 24639. Check the correct object for null. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart_work_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/html_work_manager.dart
diff --git a/pkg/analyzer/lib/src/task/html_work_manager.dart b/pkg/analyzer/lib/src/task/html_work_manager.dart
index 218b48ae27e80195fbb9c7fcfea781354751aa59..b0e52bbd658d6b104fd67dfdfbbcec809226da4f 100644
--- a/pkg/analyzer/lib/src/task/html_work_manager.dart
+++ b/pkg/analyzer/lib/src/task/html_work_manager.dart
@@ -231,7 +231,7 @@ class HtmlWorkManager implements WorkManager {
scriptTargets.forEach(partition.remove);
for (Source htmlSource in htmlSources) {
CacheEntry entry = partition.get(htmlSource);
- if (htmlSource != null) {
+ if (entry != null) {
entry.setState(HTML_ERRORS, CacheState.INVALID);
if (invalidateUris) {
entry.setState(REFERENCED_LIBRARIES, CacheState.INVALID);
« no previous file with comments | « pkg/analyzer/lib/src/task/dart_work_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698