Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414733005: [es6] Handle super properly when rewriting arrow parameter initializers (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Handle super properly when rewriting arrow parameter initializers R=rossberg@chromium.org BUG=v8:4395 LOG=y Committed: https://crrev.com/7f1504f51e71691e6b354394f1b5d699bd008284 Cr-Commit-Position: refs/heads/master@{#31440}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M src/ast-expression-visitor.cc View 1 1 chunk +11 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-4395.js View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 2 months ago (2015-10-20 09:53:34 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-10-20 10:42:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414733005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414733005/20001
5 years, 2 months ago (2015-10-21 12:51:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 13:15:54 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 13:16:18 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7f1504f51e71691e6b354394f1b5d699bd008284
Cr-Commit-Position: refs/heads/master@{#31440}

Powered by Google App Engine
This is Rietveld 408576698