Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1414733004: X87: disable the regress-undefined-nan test case for x87. (Closed)

Created:
5 years, 2 months ago by chunyang.dai
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: disable the regress-undefined-nan test case for x87. The reason is when native_context_specialization flag is ture, X87 turbofan will hit the known issue that X87 will change a sNaN to qNaN by default. And then it will fail when bit-comparing the source (sNaN) and the result (qNaN). BUG= Committed: https://crrev.com/b3c719ebbad6c87afefa33a7d0b3f412b2e304db Cr-Commit-Position: refs/heads/master@{#31530}

Patch Set 1 #

Patch Set 2 : Reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
chunyang.dai
PTAL.
5 years, 2 months ago (2015-10-23 10:00:48 UTC) #2
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-23 11:33:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414733004/1
5 years, 2 months ago (2015-10-23 15:22:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 15:48:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b3c719ebbad6c87afefa33a7d0b3f412b2e304db Cr-Commit-Position: refs/heads/master@{#31530}
5 years, 2 months ago (2015-10-23 15:48:44 UTC) #7
chunyang.dai
5 years, 1 month ago (2015-10-26 03:43:50 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1417303005/ by chunyang.dai@intel.com.

The reason for reverting is: because of merge mistake, "regress/" is missed when
skipping one test case for X87.

 "regress/" will be added when relanding it..

Powered by Google App Engine
This is Rietveld 408576698