components/navigation_interception/intercept_navigation_throttle_unittest.cc - Issue 1414723008: Add a way to cancel deferred navigations in NavigationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_throttle_unittest.cc

Issue 1414723008: Add a way to cancel deferred navigations in NavigationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/navigation_interception/intercept_navigation_throttle.cc ('k') | content/browser/frame_host/navigation_handle_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_throttle_unittest.cc

diff --git a/components/navigation_interception/intercept_navigation_throttle_unittest.cc b/components/navigation_interception/intercept_navigation_throttle_unittest.cc

index 7c95a531a7e26c928346dc2c73e2f97c7a3129d2..8c15876c8ce1dbee4c0aa6891ca2f17f390cc090 100644

--- a/components/navigation_interception/intercept_navigation_throttle_unittest.cc

+++ b/components/navigation_interception/intercept_navigation_throttle_unittest.cc

@@ -67,7 +67,8 @@ class InterceptNavigationThrottleTest

test_handle.get(),

base::Bind(

&MockInterceptCallbackReceiver::ShouldIgnoreNavigation,

- base::Unretained(mock_callback_receiver_.get()))))

+ base::Unretained(mock_callback_receiver_.get())),

+ true))

.Pass());

return test_handle->CallWillStartRequestForTesting(

is_post, content::Referrer(), false, ui::PAGE_TRANSITION_LINK, false);

@@ -83,7 +84,8 @@ class InterceptNavigationThrottleTest