content/public/browser/navigation_handle.h - Issue 1414723008: Add a way to cancel deferred navigations in NavigationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_handle.h

Issue 1414723008: Add a way to cancel deferred navigations in NavigationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Nasko's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_handle_impl.h ('K') | « content/browser/loader/navigation_resource_throttle.cc ('k') | content/public/browser/navigation_throttle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/navigation_handle.h

diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h

index 3b2bbadda772a2f31a97b5faff489b0b730728c9..e72dd51c718ecad1cc6db491586236e9b6f84471 100644

--- a/content/public/browser/navigation_handle.h

+++ b/content/public/browser/navigation_handle.h

@@ -93,6 +93,12 @@ class CONTENT_EXPORT NavigationHandle {

// Resumes a navigation that was previously deferred by a NavigationThrottle.

virtual void Resume() = 0;

+ // Cancels a navigation that was previously paused by a NavigationThrottle.

nasko 2015/11/06 17:31:59 nit: s/paused/deferred/, so we are consistent in o

clamy 2015/11/09 13:56:27 Done.

+ // |result| should be equal to NavigationThrottle::CANCEL or

+ // NavigationThrottle::CANCEL_AND_IGNORE.

+ virtual void CancelDeferredNavigation(

+ NavigationThrottle::ThrottleCheckResult result) = 0;

// Testing methods ----------------------------------------------------------

// The following methods should be used exclusively for writing unit tests.