content/browser/frame_host/navigation_handle_impl.h - Issue 1414723008: Add a way to cancel deferred navigations in NavigationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1414723008: Add a way to cancel deferred navigations in NavigationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/navigation_interception/intercept_navigation_throttle.cc ('K') | « components/navigation_interception/intercept_navigation_throttle_unittest.cc ('k') | content/browser/frame_host/navigation_handle_impl.cc » ('j') | content/browser/frame_host/navigation_handle_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_handle_impl.h

diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h

index 6f46707108e531ceac132639638d387611e5710f..2e1e64a1fb82d4bdc3c4ffaf626bd017c8ca7460 100644

--- a/content/browser/frame_host/navigation_handle_impl.h

+++ b/content/browser/frame_host/navigation_handle_impl.h

@@ -76,6 +76,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {

bool HasCommitted() override;

bool IsErrorPage() override;

void Resume() override;

+ void CancelDeferredNavigation(bool ignore) override;

void RegisterThrottleForTesting(

scoped_ptr<NavigationThrottle> navigation_throttle) override;

NavigationThrottle::ThrottleCheckResult CallWillStartRequestForTesting(

@@ -167,6 +168,8 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {

NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();

NavigationThrottle::ThrottleCheckResult CheckWillRedirectRequest();

+ void RunCompleteCallback(NavigationThrottle::ThrottleCheckResult result);

// Used in tests.

State state() const { return state_; }