Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1414723004: [turbofan] Introduce conditional builders into AstGraphBuilder. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce conditional builders into AstGraphBuilder. This re-introduces the long lost concept of conditional builder methods into the AstGraphBuilder that are allowed to return {nullptr} when a certain optimization does not apply. This can be used to separate our optimizations in the graph builder clearly from code required for correctness. R=bmeurer@chromium.org BUG=v8:4513 LOG=n Committed: https://crrev.com/335a8fc3321f78d85b96f5b6ada0963d59e7d58a Cr-Commit-Position: refs/heads/master@{#31694}

Patch Set 1 #

Patch Set 2 : Fix schtupidness! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -37 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 3 chunks +60 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-30 14:30:08 UTC) #2
Benedikt Meurer
Oh nice. LGTM!
5 years, 1 month ago (2015-10-30 14:34:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414723004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414723004/20001
5 years, 1 month ago (2015-10-30 15:03:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 15:58:50 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 15:59:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/335a8fc3321f78d85b96f5b6ada0963d59e7d58a
Cr-Commit-Position: refs/heads/master@{#31694}

Powered by Google App Engine
This is Rietveld 408576698