Only use the PGO optimizations on chrome_child.dll

Only use the PGO optimizations on chrome_child.dll

(TBR'ing the telemetry team as it's only code removal and a module that's only used by me, and the team has probably no idea of what the win_pgo_profiler does...)

TBR=sullivan@chromium.org

Committed: https://crrev.com/448a18122de7d7f17093dee61b9430cf3e69ed00
Cr-Commit-Position: refs/heads/master@{#358616}

[Sébastien Marchand, 2015-11-09 03:03:16]

Description was changed from

==========
Only use the PGO optimizations on chrome_child.dll

BUG=
==========

to

==========
Only use the PGO optimizations on chrome_child.dll

TBR=chrisha@chromium.org
==========

[Sébastien Marchand, 2015-11-09 03:03:53]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-11-09 03:03:57]

The CQ bit was unchecked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-11-09 07:28:54]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 07:29:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414713006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414713006/20001

[commit-bot: I haz the power, 2015-11-09 07:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 07:29:08]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[Sébastien Marchand, 2015-11-09 16:33:06]

Description was changed from

==========
Only use the PGO optimizations on chrome_child.dll

TBR=chrisha@chromium.org
==========

to

==========
Only use the PGO optimizations on chrome_child.dll
==========

[Sébastien Marchand, 2015-11-09 16:33:06]

sebmarchand@chromium.org changed reviewers:
+ chrisha@chromium.org

[Sébastien Marchand, 2015-11-09 16:33:13]

PTAL.

[chrisha, 2015-11-09 16:34:25]

Has this been benchmarked?

[Sébastien Marchand, 2015-11-09 16:39:37]

I'll need an official branded build for my benchmarks, and I don't have good
benchmarks for this (only the ones running on my off corp machine under my
desk). My plan was to get the builder to produce these builds so I won't have to
do it myself. I've tried to get an integration with the perf dashboards to make
this easier, but this is a really low priority for the perf-infra team right
now.

We're hitting a compiler bug with chrome.dll right now (fixed in VS2015), so
trying to optimize it is pointless as it result in a build failure.

[Sébastien Marchand, 2015-11-09 16:39:38]

I'll need an official branded build for my benchmarks, and I don't have good
benchmarks for this (only the ones running on my off corp machine under my
desk). My plan was to get the builder to produce these builds so I won't have to
do it myself. I've tried to get an integration with the perf dashboards to make
this easier, but this is a really low priority for the perf-infra team right
now.

We're hitting a compiler bug with chrome.dll right now (fixed in VS2015), so
trying to optimize it is pointless as it result in a build failure.

[chrisha, 2015-11-09 16:40:25]

On 2015/11/09 16:39:38, Sébastien Marchand wrote:
> I'll need an official branded build for my benchmarks, and I don't have good
> benchmarks for this (only the ones running on my off corp machine under my
> desk). My plan was to get the builder to produce these builds so I won't have
to
> do it myself. I've tried to get an integration with the perf dashboards to
make
> this easier, but this is a really low priority for the perf-infra team right
> now.
> 
> We're hitting a compiler bug with chrome.dll right now (fixed in VS2015), so
> trying to optimize it is pointless as it result in a build failure.

Ah, okay. lgtm

[Sébastien Marchand, 2015-11-09 16:43:14]

But I agree that in an ideal world we should have a bot/trybot that do a Chrome
checkout, compile a PGO and a non-PGO build and then run a suite of benchmarks
on these 2 builds...

[Sébastien Marchand, 2015-11-09 16:45:30]

Description was changed from

==========
Only use the PGO optimizations on chrome_child.dll
==========

to

==========
Only use the PGO optimizations on chrome_child.dll

(TBR'ing the telemetry team as it's only code removal and a module that's only
used by me, and the team has probably no idea of what the win_pgo_profiler
does...)

TBR=sullivan@chromium.org
==========

[Sébastien Marchand, 2015-11-09 16:45:43]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2015-11-09 16:46:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414713006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414713006/20001

[commit-bot: I haz the power, 2015-11-09 16:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 16:46:13]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[Sébastien Marchand, 2015-11-09 17:29:38]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-11-09 17:29:38]

The patchset sent to the CQ was uploaded after l-g-t-m from chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/1414713006/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-11-09 17:30:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414713006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414713006/40001

[commit-bot: I haz the power, 2015-11-09 18:57:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-09 18:58:21]

Patchset 3 (id:??) landed as
https://crrev.com/448a18122de7d7f17093dee61b9430cf3e69ed00
Cr-Commit-Position: refs/heads/master@{#358616}