Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1414713002: [swarming] Isolate bot_default. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Isolate bot_default. Depends on https://codereview.chromium.org/1413023002/ BUG=chromium:535160 LOG=n NOTRY=true Committed: https://crrev.com/1f7490b3dfce220bb59485c55efdcf39808ecd12 Cr-Commit-Position: refs/heads/master@{#31363}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + test/bot_default.gyp View 1 2 chunks +3 lines, -2 lines 0 comments Download
A + test/bot_default.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
PTAL
5 years, 2 months ago (2015-10-19 09:22:24 UTC) #2
Jakob Kummerow
lgtm
5 years, 2 months ago (2015-10-19 09:27:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414713002/20001
5 years, 2 months ago (2015-10-19 09:34:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-19 09:52:36 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 09:52:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f7490b3dfce220bb59485c55efdcf39808ecd12
Cr-Commit-Position: refs/heads/master@{#31363}

Powered by Google App Engine
This is Rietveld 408576698