Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1414703004: mac: Remove libc++ hack that was required by NaCl. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove libc++ hack that was required by NaCl. NaCl target were still built with the 10.6 SDK even after we thought we switched the whole build to the 10.10 SDK. This was a problem in static library ASan builds: -fsanitize=address implicitly requires libc++, so this added a -lc++ to the link, but the 10.6 SDK doesn't contain a libc++ (since ASan requires 10.7, and since it also adds an implicit -lc++abi, we dynamically link libc++ in ASan builds). This led to linker errors. Now that NaCl targets build with the 10.10 SDK like everything else when they're part of a Chromium build, the hack I used to work around this is no longer needed, so remove it. No intended behavior change. BUG=400091 Committed: https://crrev.com/e1c27eab364747ef85275615835bf56514916696 Cr-Commit-Position: refs/heads/master@{#356325}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix a typo too #

Patch Set 4 : typo2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -45 lines) Patch
M build/common.gypi View 1 2 chunks +21 lines, -43 lines 0 comments Download
M third_party/libc++-static/README.chromium View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
This brings trunk back to how things looked in the CL you reviewed last week. ...
5 years, 1 month ago (2015-10-27 05:38:10 UTC) #2
Nico
(please click through to patch set 2, i forgot something in patch set 1)
5 years, 1 month ago (2015-10-27 05:44:09 UTC) #3
Mark Mentovai
I went all the way to patch set 4 and LGTM.
5 years, 1 month ago (2015-10-27 16:20:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414703004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414703004/60001
5 years, 1 month ago (2015-10-27 16:28:07 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-27 17:23:39 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 17:24:34 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e1c27eab364747ef85275615835bf56514916696
Cr-Commit-Position: refs/heads/master@{#356325}

Powered by Google App Engine
This is Rietveld 408576698