Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1414693011: Adds unmodified source files from golang.org. (Closed)

Created:
5 years, 1 month ago by rudominer
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds unmodified source files from golang.org. BUG=#461 R=jamesr@chromium.org, jamesr This initial patch contains unmodified source. In the next patch I will make a small change to one of the files. This is needed by the testing infrastructure for the new Mojom parser. Committed: https://chromium.googlesource.com/external/mojo/+/230010ba9d5e93d9f4d039a45adccc7cd4daadaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1811 lines, -6 lines) Patch
A + third_party/golang/LICENSE View 2 chunks +5 lines, -6 lines 0 comments Download
A third_party/golang/README View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/golang/src/fmt/fmt.go View 1 chunk +535 lines, -0 lines 0 comments Download
A third_party/golang/src/fmt/print.go View 1 chunk +1259 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rudominer
Hi James, ptal. I called the readme file README instead of README.chromium. Let me know ...
5 years, 1 month ago (2015-11-04 22:34:57 UTC) #6
jamesr
Seems fine process wise, although forking the 'fmt' package seems a little strange. how will ...
5 years, 1 month ago (2015-11-04 22:39:03 UTC) #7
jamesr
lgtm (missed the button)
5 years, 1 month ago (2015-11-04 22:41:21 UTC) #8
rudominer
On 2015/11/04 22:39:03, jamesr wrote: > Seems fine process wise, although forking the 'fmt' package ...
5 years, 1 month ago (2015-11-04 22:45:27 UTC) #9
rudominer
5 years, 1 month ago (2015-11-04 22:46:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
230010ba9d5e93d9f4d039a45adccc7cd4daadaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698