Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc

Issue 1414683003: Fix gpu command buffer use after free by GrContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fixup Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
diff --git a/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc b/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
index dc4b236d2cc555d34de925d7ddb0c8e0553b7a6a..9afc900d6513d57a7982022b3d62e1db8e4ab985 100644
--- a/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
+++ b/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
@@ -15,8 +15,7 @@
namespace skia_bindings {
-GrGLInterface* CreateCommandBufferSkiaGLBinding() {
- GrGLInterface* interface = new GrGLInterface;
+void InitCommandBufferSkiaGLBinding(GrGLInterface* interface) {
interface->fStandard = kGLES_GrGLStandard;
interface->fExtensions.init(kGLES_GrGLStandard,
glGetString,
@@ -180,8 +179,6 @@ GrGLInterface* CreateCommandBufferSkiaGLBinding() {
glProgramPathFragmentInputGenCHROMIUM;
functions->fBindFragmentInputLocation = glBindFragmentInputLocationCHROMIUM;
}
-
- return interface;
}
} // namespace skia
« no previous file with comments | « gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h ('k') | third_party/WebKit/public/platform/WebGraphicsContext3D.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698