Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: gpu/blink/webgraphicscontext3d_impl.cc

Issue 1414683003: Fix gpu command buffer use after free by GrContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fixup Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/blink/webgraphicscontext3d_impl.h ('k') | gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/blink/webgraphicscontext3d_impl.cc
diff --git a/gpu/blink/webgraphicscontext3d_impl.cc b/gpu/blink/webgraphicscontext3d_impl.cc
index 040d7e1c068f51443d86d0a5fc79f86589a935ab..139dacecb30c316b4e4d7385c7e1363a102aeb29 100644
--- a/gpu/blink/webgraphicscontext3d_impl.cc
+++ b/gpu/blink/webgraphicscontext3d_impl.cc
@@ -12,7 +12,6 @@
#include "gpu/command_buffer/client/gles2_lib.h"
#include "gpu/command_buffer/common/gles2_cmd_utils.h"
#include "gpu/command_buffer/common/sync_token.h"
-#include "gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h"
#include "third_party/khronos/GLES2/gl2.h"
#ifndef GL_GLEXT_PROTOTYPES
@@ -1212,10 +1211,6 @@ blink::WGC3Denum WebGraphicsContext3DImpl::getGraphicsResetStatusARB() {
return gl_->GetGraphicsResetStatusKHR();
}
-GrGLInterface* WebGraphicsContext3DImpl::createGrGLInterface() {
- return skia_bindings::CreateCommandBufferSkiaGLBinding();
-}
-
::gpu::gles2::GLES2ImplementationErrorMessageCallback*
WebGraphicsContext3DImpl::getErrorMessageCallback() {
if (!client_error_message_callback_) {
« no previous file with comments | « gpu/blink/webgraphicscontext3d_impl.h ('k') | gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698