content/common/frame_messages.h - Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed "Guest" to "InnerContents" Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/site_per_process_browsertest.cc ('K') | « content/browser/site_per_process_browsertest.cc ('k') | content/renderer/render_frame_proxy.h » ('j') | third_party/WebKit/Source/core/frame/RemoteFrameView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index c67cd766bfa3a81354b071f6c96d5571c87d0fe7..00dbff256974fdad8af9ddbf0efc59e2627abbb9 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -1079,6 +1079,10 @@ IPC_MESSAGE_ROUTED1(FrameHostMsg_ForwardInputEvent,

// position of a child's ancestor has changed).

IPC_MESSAGE_ROUTED1(FrameHostMsg_FrameRectChanged, gfx::Rect /* frame_rect */)

+// Informs the child that the frame has changed visibility. This message will

+// be then forwarded to the guest WebContents.

Charlie Reis 2015/11/20 23:35:29 nit: guest -> inner. It's also not clear to me fr

EhsanK 2015/12/07 16:10:15 The second sentence was confusing so I removed it.

+IPC_MESSAGE_ROUTED1(FrameHostMsg_VisibilityChanged, bool /* visible */)

// Used to tell the parent that the user right clicked on an area of the

// content area, and a context menu should be shown for it. The params

// object contains information about the node(s) that were selected when the