third_party/WebKit/Source/web/tests/FrameTestHelpers.h - Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased & Added Blink Unit Tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp ('K') | « third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

index 3f91ae389c8c5a81503a74c3c91ca4bf6e824a71..45b09126c01539f6b48e4f091e22c90b770459fb 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

@@ -163,9 +163,13 @@ public:

WebRemoteFrame* targetFrame,

WebSecurityOrigin targetOrigin,

WebDOMMessageEvent) override { }

+ void visibilityChanged(bool visible) override { m_visible = visible; }

dcheng 2016/01/06 18:43:58 Move these to a subclass of TestWebRemoteFrameClie

EhsanK 2016/01/08 22:05:37 Done.

+ bool isVisible() { return m_visible; }

dcheng 2016/01/06 18:43:58 Nit: const

EhsanK 2016/01/08 22:05:37 Done.

private:

RawPtrWillBePersistent<WebRemoteFrameImpl> const m_frame;

+ bool m_visible;

};

class TestWebViewClient : public WebViewClient {