Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrameView.cpp

Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased & Added Blink Unit Tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp b/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
index d99f6074f164079a8e620f56b1ca13ec1ce1c258..6df7d7c99464640c9a2316091c41493fc7387a9a 100644
--- a/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
@@ -66,6 +66,36 @@ void RemoteFrameView::frameRectsChanged()
m_remoteFrame->frameRectsChanged(frameRect());
}
+void RemoteFrameView::hide()
+{
+ setSelfVisible(false);
+
+ Widget::hide();
+
+ m_remoteFrame->visibilityChanged(false);
+}
+
+void RemoteFrameView::show()
+{
+ setSelfVisible(true);
+
+ Widget::show();
+
+ m_remoteFrame->visibilityChanged(true);
+}
+
+void RemoteFrameView::setParentVisible(bool visible)
+{
+ if (isParentVisible() == visible)
+ return;
+
+ Widget::setParentVisible(visible);
+ if (!isSelfVisible())
+ return;
+
+ m_remoteFrame->visibilityChanged(isVisible());
+}
+
DEFINE_TRACE(RemoteFrameView)
{
visitor->trace(m_remoteFrame);

Powered by Google App Engine
This is Rietveld 408576698