content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added Tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/cross_process_frame_connector.h ('K') | « content/browser/frame_host/render_widget_host_view_child_frame.h ('k') | content/browser/renderer_host/render_widget_host_delegate.h » ('j') | content/browser/renderer_host/render_widget_host_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index 1324f77e15c2eef56d5b3e58849ed79b69f6f723..c31a90ce99ff479d9e661a97f32683a2e8a93569 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -482,4 +482,15 @@ void RenderWidgetHostViewChildFrame::ClearCompositorSurfaceIfNecessary() {

surface_id_ = cc::SurfaceId();

}

+// This method is called only when the renderer changes the visibility of the

+// corresponding frame.

+void RenderWidgetHostViewChildFrame::SetVisibility(bool visible) {

+ if (host_->delegate()->DidForwardVisibilityChangeToGuest(visible))

+ return;

+ if (visible)

+ Show();

+ else

+ Hide();

} // namespace content