Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

content/browser/frame_host/cross_process_frame_connector.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/cross_process_frame_connector.h"
 
 #include "cc/surfaces/surface.h"
 #include "cc/surfaces/surface_manager.h"
 #include "content/browser/compositor/surface_utils.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/render_frame_host_manager.h"
 #include "content/browser/frame_host/render_frame_proxy_host.h"
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
+#include "content/browser/renderer_host/render_widget_host_delegate.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/common/frame_messages.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 
 namespace content {
 
 CrossProcessFrameConnector::CrossProcessFrameConnector(
     RenderFrameProxyHost* frame_proxy_in_parent_renderer)
@@ skipping 10 matching lines @@
 bool CrossProcessFrameConnector::OnMessageReceived(const IPC::Message& msg) {
   bool handled = true;
 
   IPC_BEGIN_MESSAGE_MAP(CrossProcessFrameConnector, msg)
     IPC_MESSAGE_HANDLER(FrameHostMsg_CompositorFrameSwappedACK,
                         OnCompositorFrameSwappedACK)
     IPC_MESSAGE_HANDLER(FrameHostMsg_ReclaimCompositorResources,
                         OnReclaimCompositorResources)
     IPC_MESSAGE_HANDLER(FrameHostMsg_ForwardInputEvent, OnForwardInputEvent)
     IPC_MESSAGE_HANDLER(FrameHostMsg_FrameRectChanged, OnFrameRectChanged)
+    IPC_MESSAGE_HANDLER(FrameHostMsg_VisibilityChanged, OnVisibilityChanged)
     IPC_MESSAGE_HANDLER(FrameHostMsg_InitializeChildFrame,
                         OnInitializeChildFrame)
     IPC_MESSAGE_HANDLER(FrameHostMsg_SatisfySequence, OnSatisfySequence)
     IPC_MESSAGE_HANDLER(FrameHostMsg_RequireSequence, OnRequireSequence)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
@@ skipping 164 matching lines @@
     return;
   }
 }
 
 void CrossProcessFrameConnector::OnFrameRectChanged(
     const gfx::Rect& frame_rect) {
   if (!frame_rect.size().IsEmpty())
     SetSize(frame_rect);
 }
 
+void CrossProcessFrameConnector::OnVisibilityChanged(bool visible) {
+  if (!view_)
+    return;
+
+  if (frame_proxy_in_parent_renderer_->frame_tree_node()

[Charlie Reis, 2015/12/10 07:45:19]

I feel like this is a bit hard to follow.  Can you add a comment explaining it?

[EhsanK, 2015/12/10 17:08:31]

This part is checking if the corresponding RWHVCF corresponds to the main frame
of <webview>. Before this I was simply checking if a BrowserPluginGuest exists
in the WebContents but lazyboy@ pointed me towards this line.

I have removed this logic from the CL. I will add it again (with comments) in
the next one.

+          ->render_manager()
+          ->ForInnerDelegate()) {
+    RenderWidgetHostImpl::From(view_->GetRenderWidgetHost())
+        ->delegate()
+        ->ForwardVisibilityChangeToInnerContents(visible);
+    return;
+  }
+
+  if (visible)
+    view_->Show();
+  else
+    view_->Hide();
+}
+
 void CrossProcessFrameConnector::SetDeviceScaleFactor(float scale_factor) {
   device_scale_factor_ = scale_factor;
   // The RenderWidgetHost is null in unit tests.
   if (view_ && view_->GetRenderWidgetHost()) {
     RenderWidgetHostImpl* child_widget =
         RenderWidgetHostImpl::From(view_->GetRenderWidgetHost());
     child_widget->NotifyScreenInfoChanged();
   }
 }
 
@@ skipping 12 matching lines @@
   // in the case of nested WebContents.
   while (top_host->frame_tree_node()->render_manager()->ForInnerDelegate()) {
     top_host = top_host->frame_tree_node()->render_manager()->
         GetOuterDelegateNode()->frame_tree()->root()->current_frame_host();
   }
 
   return static_cast<RenderWidgetHostViewBase*>(top_host->GetView());
 }
 
 }  // namespace content