Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

content/browser/renderer_host/render_widget_host_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 105 matching lines @@
   // Requests the renderer to select the region between two points in the
   // currently focused frame.
   virtual void SelectRange(const gfx::Point& base, const gfx::Point& extent) {}
 
   virtual RenderWidgetHostInputEventRouter* GetInputEventRouter();
 
   // Send page-level focus state to all SiteInstances involved in rendering the
   // current FrameTree, not including the main frame's SiteInstance.
   virtual void ReplicatePageFocus(bool is_focused) {}
 
+  // If there is a guest WebContents, it should be notified of the visibility
+  // change.
+  virtual void ForwardVisibilityChangeToInnerContents(bool visible) {}

[Charlie Reis, 2015/12/08 19:18:33]

This isn't implemented anywhere.  Is it stale, or do you plan to override it
somewhere?

(We should either implement it now or leave this part out of this CL and add it
when you're ready.)

[EhsanK, 2015/12/09 00:14:16]

I did override it in WebContentsImpl. Purely, this method's purpose is to inform
the out of process renderer of the visibility change and is only valid for
<guestview>'s. That is why I initially left out the implementation to make this
CL only related to oopif.

[Charlie Reis, 2015/12/10 07:45:19]

Leaving it out for now would be fine, but if so we should leave out this
declaration (and the call) as well as the implementation, adding them both
later.

(I'm fine either way at this point.)

+
   // Get the focused RenderWidgetHost associated with |receiving_widget|. A
   // RenderWidgetHostView, upon receiving a keyboard event, will pass its
   // RenderWidgetHost to this function to determine who should ultimately
   // consume the event.  This facilitates keyboard event routing with
   // out-of-process iframes, where multiple RenderWidgetHosts may be involved
   // in rendering a page, yet keyboard events all arrive at the main frame's
   // RenderWidgetHostView.  When a main frame's RenderWidgetHost is passed in,
   // the function returns the focused frame that should consume keyboard
   // events. In all other cases, the function returns back |receiving_widget|.
   virtual RenderWidgetHostImpl* GetFocusedRenderWidgetHost(
@@ skipping 43 matching lines @@
   virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
                                       const std::vector<uint8_t>& proto) {}
 
  protected:
   virtual ~RenderWidgetHostDelegate() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_