Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1414653003: use (temp) gpu-imagefilter-cache for applyFilter (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use (temp) gpu-imagefilter-cache for applyFilter BUG=skia: Committed: https://skia.googlesource.com/skia/+/13ccbf8a681d69e4685849d9dedeabea0fea7773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M src/gpu/SkGpuDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
ptal this should fix the valgrind memory leak, since now we explicitly tear-down the "cache" ...
5 years, 2 months ago (2015-10-20 16:39:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414653003/1
5 years, 2 months ago (2015-10-20 16:39:46 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-20 16:39:47 UTC) #5
bsalomon
lgtm
5 years, 2 months ago (2015-10-20 16:41:50 UTC) #6
mtklein
lgtm
5 years, 2 months ago (2015-10-20 16:50:18 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 16:56:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/13ccbf8a681d69e4685849d9dedeabea0fea7773

Powered by Google App Engine
This is Rietveld 408576698