Issue 1414653002: Disable completion of formal parameter names as *types*.

Issue 1414653002: Disable completion of formal parameter names as types. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Disable completion of formal parameter names as *types*. R=brianwilkerson@google.com, danrubel@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3b198ed6ae1af640759da49f115fce3739e82712

Patch Set 2 : tweaks #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -7 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/optype.dart	View	1	2 chunks	+34 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_test_util.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/optype_test.dart	View		3 chunks	+51 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danrubel

LGTM. Thanks! https://codereview.chromium.org/1414653002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart File pkg/analysis_server/lib/src/services/completion/optype.dart (right): https://codereview.chromium.org/1414653002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart#newcode331 pkg/analysis_server/lib/src/services/completion/optype.dart:331: if (entity.previous != null && Is this ...

5 years, 2 months ago (2015-10-18 19:46:03 UTC) #3

scheglov

https://codereview.chromium.org/1414653002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart File pkg/analysis_server/lib/src/services/completion/optype.dart (right): https://codereview.chromium.org/1414653002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart#newcode331 pkg/analysis_server/lib/src/services/completion/optype.dart:331: if (entity.previous != null && On 2015/10/18 19:46:02, danrubel ...

5 years, 2 months ago (2015-10-18 20:27:49 UTC) #4

scheglov

5 years, 2 months ago (2015-10-18 20:28:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3b198ed6ae1af640759da49f115fce3739e82712 (presubmit successful).

Expand Messages | Collapse Messages