Disable zoom bubble for PDF extension.

Disable zoom bubble for PDF extension.

The location-bar zoom bubble is interfering with the material-design
top-toolbar in the PDF viewer. Since the viewer is a trusted extension,
we can disable the bubble for it.

BUG=538252
Committed: https://crrev.com/70eb6d831495b034bc6c2ed259de428f933a8386
Cr-Commit-Position: refs/heads/master@{#356946}

[wjmaclean, 2015-10-20 19:09:13]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[wjmaclean, 2015-10-20 19:09:54]

Description was changed from

==========
Disable zoom bubble for PDF extension.

The location-bar zoom bubble is interfering with the material-design
top-toolbar in the PDF viewer. Since the viewer is a trusted extension,
we can disable the bubble for it.

BUG=
==========

to

==========
Disable zoom bubble for PDF extension.

The location-bar zoom bubble is interfering with the material-design
top-toolbar in the PDF viewer. Since the viewer is a trusted extension,
we can disable the bubble for it.

BUG=
==========

[wjmaclean, 2015-10-20 19:09:54]

wjmaclean@chromium.org changed reviewers:
+ rockot@chromium.org, thestig@chromium.org

[commit-bot: I haz the power, 2015-10-20 19:09:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/1

[commit-bot: I haz the power, 2015-10-20 19:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 19:49:32]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wjmaclean, 2015-10-20 23:41:31]

Description was changed from

==========
Disable zoom bubble for PDF extension.

The location-bar zoom bubble is interfering with the material-design
top-toolbar in the PDF viewer. Since the viewer is a trusted extension,
we can disable the bubble for it.

BUG=
==========

to

==========
Disable zoom bubble for PDF extension.

The location-bar zoom bubble is interfering with the material-design
top-toolbar in the PDF viewer. Since the viewer is a trusted extension,
we can disable the bubble for it.

BUG=538252
==========

[wjmaclean, 2015-10-21 14:55:13]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 14:55:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/20001

[commit-bot: I haz the power, 2015-10-21 15:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 15:36:50]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2015-10-21 15:45:07]

Smallish-cl ... I think this will do what we need. Please take a look?

[Ken Rockot(use gerrit already), 2015-10-21 16:53:31]

lgtm, thanks!

https://codereview.chromium.org/1414643005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_util.cc (right):

https://codereview.chromium.org/1414643005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_util.cc:201: bool ZoomWithoutBubble(const
Extension* extension) {
nit: How about "CanZoomWithoutBubble" or "AllowZoomWithoutBubble"? i.e.
something to convey that it's a test for permission rather than an imperative
command

https://codereview.chromium.org/1414643005/diff/20001/extensions/common/api/_...
File extensions/common/api/_behavior_features.json (right):

https://codereview.chromium.org/1414643005/diff/20001/extensions/common/api/_...
extensions/common/api/_behavior_features.json:55:
"CBCC42ABED43A4B58FE3810E62AFFA010EB0349F"   // pdf-viewer
nit: Please replace this comment with a link to the bug

[wjmaclean, 2015-10-21 16:59:47]

https://codereview.chromium.org/1414643005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_util.cc (right):

https://codereview.chromium.org/1414643005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_util.cc:201: bool ZoomWithoutBubble(const
Extension* extension) {
On 2015/10/21 16:53:30, Ken Rockot wrote:
> nit: How about "CanZoomWithoutBubble" or "AllowZoomWithoutBubble"? i.e.
> something to convey that it's a test for permission rather than an imperative
> command

Done.

I like "AllowZoomWithoutBubble()" ... let's go with that!

https://codereview.chromium.org/1414643005/diff/20001/extensions/common/api/_...
File extensions/common/api/_behavior_features.json (right):

https://codereview.chromium.org/1414643005/diff/20001/extensions/common/api/_...
extensions/common/api/_behavior_features.json:55:
"CBCC42ABED43A4B58FE3810E62AFFA010EB0349F"   // pdf-viewer
On 2015/10/21 16:53:30, Ken Rockot wrote:
> nit: Please replace this comment with a link to the bug

Done.

[Lei Zhang, 2015-10-21 17:05:12]

lgtm

[Lei Zhang, 2015-10-21 17:05:26]

Anyway, we can add an automated test?

[wjmaclean, 2015-10-21 17:32:56]

On 2015/10/21 17:05:26, Lei Zhang wrote:
> Anyway, we can add an automated test?

I'll look into that ...

[wjmaclean, 2015-10-23 13:21:06]

wjmaclean@chromium.org changed reviewers:
+ jochen@chromium.org

[wjmaclean, 2015-10-23 13:21:07]

jochen@ - please review changes to components/ui_zoom.gypi
thestig@ - please take another look; pdf_extension_test.cc and DEPS for
chrome/browser

[wjmaclean, 2015-10-23 13:21:53]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 13:22:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/60001

[commit-bot: I haz the power, 2015-10-23 13:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 13:24:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wjmaclean, 2015-10-23 14:24:30]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 14:24:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/80001

[commit-bot: I haz the power, 2015-10-23 14:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 14:32:05]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wjmaclean, 2015-10-23 14:44:56]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 14:45:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/100001

[commit-bot: I haz the power, 2015-10-23 14:53:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 14:53:13]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wjmaclean, 2015-10-23 17:11:17]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 17:11:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/120001

[wjmaclean, 2015-10-23 17:12:10]

Patchset #7 (id:120001) has been deleted

[wjmaclean, 2015-10-23 17:13:50]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 17:14:01]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2015-10-23 17:14:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/140001

[wjmaclean, 2015-10-23 17:16:09]

I realized the previous approach involved a pathway that had no counterpart on
Mac, so I've revised this to something common to both Mac and non-Mac.

PTAL (rockot@ - I've removed the changes to extension_util.*, but added
basically the same code to extension_zoom_request_client ... can you please take
another look?)

[commit-bot: I haz the power, 2015-10-23 17:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 17:16:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2015-10-23 17:58:43]

cool, lgtm

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:462: EXPECT_EQ(nullptr,
ZoomBubbleView::GetZoomBubble());
Sorry, I don't know much about zoom or Mac; is there nothing that can be tested
to verify behavior on Mac? Or is it not an issue on Mac for some reason?

[Ken Rockot(use gerrit already), 2015-10-23 17:59:00]

On 2015/10/23 17:58:43, Ken Rockot wrote:
> cool, lgtm
> 
>
https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
> File chrome/browser/pdf/pdf_extension_test.cc (right):
> 
>
https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
> chrome/browser/pdf/pdf_extension_test.cc:462: EXPECT_EQ(nullptr,
> ZoomBubbleView::GetZoomBubble());
> Sorry, I don't know much about zoom or Mac; is there nothing that can be
tested
> to verify behavior on Mac? Or is it not an issue on Mac for some reason?

also, looks like a rebase is needed!

[Lei Zhang, 2015-10-23 18:14:32]

mostly nitty:

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/DEPS
File chrome/browser/DEPS (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/DEPS#ne...
chrome/browser/DEPS:180: # The next line is needed for
chrome/browser/pdf/pdf_extension_test.cc.
Restrict this to chrome/browser/pdf/DEPS then?

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:25: #if !defined(OS_MACOSX)
platform-specific #includes go in a separate section after the main #includes.

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:25: #if !defined(OS_MACOSX)
should this be TOOLKIT_VIEWS, since there exists Mac + Views in some form?

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:439: find(preset_zoom_levels.begin(),
preset_zoom_levels.end(), 0.0);
std::find?

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/ui/zoom...
File chrome/browser/ui/zoom/zoom_controller_unittest.cc (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/ui/zoom...
chrome/browser/ui/zoom/zoom_controller_unittest.cc:24: using
ui_zoom::ZoomChangedWatcher;
Change before Control

https://codereview.chromium.org/1414643005/diff/140001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/test/BUILD.gn#n...
chrome/test/BUILD.gn:119: "//components/ui/zoom:zoom_test_utils",
Everyone else likes to names their test target test_support.

https://codereview.chromium.org/1414643005/diff/140001/components/ui/zoom/DEPS
File components/ui/zoom/DEPS (right):

https://codereview.chromium.org/1414643005/diff/140001/components/ui/zoom/DEP...
components/ui/zoom/DEPS:2: "+base",
no need for +base, that's already in src/DEPS

https://codereview.chromium.org/1414643005/diff/140001/components/ui/zoom/DEP...
components/ui/zoom/DEPS:5: "+content/public/test",
do you want to add a zoom/test sub-directory and only allow this in
zoom/test/DEPS ?

[wjmaclean, 2015-10-23 22:30:22]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 22:32:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/60002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/60002

[commit-bot: I haz the power, 2015-10-23 22:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 22:38:00]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[wjmaclean, 2015-10-24 01:04:51]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-24 01:05:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/170001

[commit-bot: I haz the power, 2015-10-24 01:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-24 01:10:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jochen (gone - plz use gerrit), 2015-10-26 15:42:14]

lgtm

[wjmaclean, 2015-10-29 15:33:36]

Sorry for the hiatus on this CL; I was away at an off-site for the last few
days.

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/DEPS
File chrome/browser/DEPS (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/DEPS#ne...
chrome/browser/DEPS:180: # The next line is needed for
chrome/browser/pdf/pdf_extension_test.cc.
On 2015/10/23 18:14:32, Lei Zhang wrote:
> Restrict this to chrome/browser/pdf/DEPS then?

Ok, I didn't realize that would be allowed :-)

Done

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:25: #if !defined(OS_MACOSX)
On 2015/10/23 18:14:32, Lei Zhang wrote:
> platform-specific #includes go in a separate section after the main #includes.

Done.

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:25: #if !defined(OS_MACOSX)
On 2015/10/23 18:14:32, Lei Zhang wrote:
> should this be TOOLKIT_VIEWS, since there exists Mac + Views in some form?

Hmm, when I try using TOOLKIT_VIEWS, I still seem to hit compilation errors on
some mac bots ... the compilation errors are directly related to ZoomBubbleView,
so I'm guessing it's not safe to reference this even if TOOLKIT_VIEWS is
specified.

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:439: find(preset_zoom_levels.begin(),
preset_zoom_levels.end(), 0.0);
On 2015/10/23 18:14:32, Lei Zhang wrote:
> std::find?

Done.

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:462: EXPECT_EQ(nullptr,
ZoomBubbleView::GetZoomBubble());
On 2015/10/23 17:58:43, Ken Rockot wrote:
> Sorry, I don't know much about zoom or Mac; is there nothing that can be
tested
> to verify behavior on Mac? Or is it not an issue on Mac for some reason?

This test *does* have a testable on Mac; the can_show_bubble == false in
ZoomChangedEventData will fail if the zoom bubble gets shown ... it's indirect,
but Mac had no way (that I currently know of) to check the ZoomBubble's
existence itself. Still, since the pathway is the same now on both Mac &
non-Mac, I think this will be enough.

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/ui/zoom...
File chrome/browser/ui/zoom/zoom_controller_unittest.cc (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/browser/ui/zoom...
chrome/browser/ui/zoom/zoom_controller_unittest.cc:24: using
ui_zoom::ZoomChangedWatcher;
On 2015/10/23 18:14:32, Lei Zhang wrote:
> Change before Control

Done.

https://codereview.chromium.org/1414643005/diff/140001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1414643005/diff/140001/chrome/test/BUILD.gn#n...
chrome/test/BUILD.gn:119: "//components/ui/zoom:zoom_test_utils",
On 2015/10/23 18:14:32, Lei Zhang wrote:
> Everyone else likes to names their test target test_support.

Done.

https://codereview.chromium.org/1414643005/diff/140001/components/ui/zoom/DEPS
File components/ui/zoom/DEPS (right):

https://codereview.chromium.org/1414643005/diff/140001/components/ui/zoom/DEP...
components/ui/zoom/DEPS:2: "+base",
On 2015/10/23 18:14:32, Lei Zhang wrote:
> no need for +base, that's already in src/DEPS

Done.

https://codereview.chromium.org/1414643005/diff/140001/components/ui/zoom/DEP...
components/ui/zoom/DEPS:5: "+content/public/test",
On 2015/10/23 18:14:32, Lei Zhang wrote:
> do you want to add a zoom/test sub-directory and only allow this in
> zoom/test/DEPS ?

Done.

[Lei Zhang, 2015-10-29 16:40:33]

https://codereview.chromium.org/1414643005/diff/170001/chrome/browser/pdf/pdf...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/1414643005/diff/170001/chrome/browser/pdf/pdf...
chrome/browser/pdf/pdf_extension_test.cc:50: #if defined(TOOLKIT_VIEWS)
I'd do this for now: #if defined(TOOLKIT_VIEWS) && !defined(OS_MACOSX)

[Lei Zhang, 2015-10-29 16:41:16]

Otherwise lgtm++

[wjmaclean, 2015-10-29 17:57:42]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 17:58:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/190001

[commit-bot: I haz the power, 2015-10-29 18:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 18:02:11]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wjmaclean, 2015-10-29 18:39:05]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 18:40:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/210001

[commit-bot: I haz the power, 2015-10-29 18:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 18:42:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wjmaclean, 2015-10-29 18:48:46]

Patchset #11 (id:210001) has been deleted

[wjmaclean, 2015-10-29 18:49:58]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 18:50:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/230001

[commit-bot: I haz the power, 2015-10-29 18:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 18:52:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wjmaclean, 2015-10-29 19:38:26]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 19:38:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/250001

[commit-bot: I haz the power, 2015-10-29 20:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 20:53:56]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2015-10-29 21:00:49]

The CQ bit was checked by wjmaclean@chromium.org

[wjmaclean, 2015-10-29 21:00:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
thestig@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1414643005/#ps250001
(title: "Test rebuilding patch from .diff file.")

[commit-bot: I haz the power, 2015-10-29 21:02:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414643005/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414643005/250001

[commit-bot: I haz the power, 2015-10-29 21:10:17]

Committed patchset #12 (id:250001)

[commit-bot: I haz the power, 2015-10-29 21:11:56]

Patchset 12 (id:??) landed as
https://crrev.com/70eb6d831495b034bc6c2ed259de428f933a8386
Cr-Commit-Position: refs/heads/master@{#356946}