Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/flags/SkCommandLineFlags.cpp

Issue 1414643002: Enable BUILD file compilation of skia and dm with --config=android_arm. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.public ('K') | « tools/BUILD_simulator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/flags/SkCommandLineFlags.cpp
diff --git a/tools/flags/SkCommandLineFlags.cpp b/tools/flags/SkCommandLineFlags.cpp
index fe3dfd193d08bf171ab0ecbabed141292c519ede..8120ecc5e302a4a6cef900472ed2174c387482f2 100644
--- a/tools/flags/SkCommandLineFlags.cpp
+++ b/tools/flags/SkCommandLineFlags.cpp
@@ -11,7 +11,12 @@
#include <stdlib.h>
+#if defined(GOOGLE3) && defined(SK_BUILD_FOR_ANDROID)
+// I don't know why, but this is defined by //base only for Android.
+DECLARE_bool(undefok)
mtklein 2015/10/20 17:48:55 .... wow, this works? That's a huge surprise. Pr
dogben 2015/10/20 22:21:03 s/convenient/inconvenient/, since whether it's def
+#else
DEFINE_bool(undefok, false, "Silently ignore unknown flags instead of crashing.");
+#endif
template <typename T> static void ignore_result(const T&) {}
« BUILD.public ('K') | « tools/BUILD_simulator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698