tools/flags/SkCommandLineFlags.cpp - Issue 1414643002: Enable BUILD file compilation of skia and dm with --config=android_arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/flags/SkCommandLineFlags.cpp

Issue 1414643002: Enable BUILD file compilation of skia and dm with --config=android_arm. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Use -mfpu=neon everywhere for Android; fold opts targets back into srcs. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/flags/SkCommandLineFlags.cpp

diff --git a/tools/flags/SkCommandLineFlags.cpp b/tools/flags/SkCommandLineFlags.cpp

index fe3dfd193d08bf171ab0ecbabed141292c519ede..2fe7824c84e465e652648500e5cfe2c684a80120 100644

--- a/tools/flags/SkCommandLineFlags.cpp

+++ b/tools/flags/SkCommandLineFlags.cpp

@@ -11,7 +11,12 @@

#include <stdlib.h>

-DEFINE_bool(undefok, false, "Silently ignore unknown flags instead of crashing.");

+#if defined(GOOGLE3) && defined(SK_BUILD_FOR_ANDROID)

+ // I don't know why, but this is defined by //base only for Android.

+ DECLARE_bool(undefok)

+#else

+ DEFINE_bool(undefok, false, "Silently ignore unknown flags instead of crashing.");

+#endif

template <typename T> static void ignore_result(const T&) {}

« no previous file with comments | « tools/BUILD_simulator.py ('k') | no next file » | no next file with comments »