Catch IllegalStateException when creating the watchdog player

Catch IllegalStateException when creating the watchdog player

It is possible that MediaPlayer.create() can throw an
IllegalStateException.
Catch the exception and treat it as a media server crash

BUG=549601
Committed: https://crrev.com/899bc6eb47d766858b88062f9f9833a327d654a1
Cr-Commit-Position: refs/heads/master@{#357198}

[qinmin, 2015-10-30 19:23:17]

qinmin@chromium.org changed reviewers:
+ timav@chromium.org, xhwang@chromium.org

[qinmin, 2015-10-30 19:23:17]

PTAL

[xhwang, 2015-10-30 19:30:28]

rs LGTM

[qinmin, 2015-10-30 20:14:51]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2015-10-30 20:16:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414603008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414603008/1

[commit-bot: I haz the power, 2015-10-30 20:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 20:30:53]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qinmin, 2015-10-30 20:59:21]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org
- timav@chromium.org

[qinmin, 2015-10-30 20:59:21]

+tedchoc for OWNER

[Ted C, 2015-10-30 21:12:55]

lgtm

[qinmin, 2015-10-30 21:18:24]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2015-10-30 21:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414603008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414603008/1

[commit-bot: I haz the power, 2015-10-30 21:26:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-30 21:27:26]

Patchset 1 (id:??) landed as
https://crrev.com/899bc6eb47d766858b88062f9f9833a327d654a1
Cr-Commit-Position: refs/heads/master@{#357198}

[Tima Vaisburd, 2015-10-30 21:54:36]

timav@chromium.org changed reviewers:
+ timav@chromium.org

[Tima Vaisburd, 2015-10-30 21:54:37]

https://codereview.chromium.org/1414603008/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/MediaThrottler.java
(right):

https://codereview.chromium.org/1414603008/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/MediaThrottler.java:106:
try {
drive-by: The documentation does not seem to tell about exceptions at all, why
not to catch all exceptions instead of just IllegalStateException?

[qinmin, 2015-10-30 21:58:16]

https://codereview.chromium.org/1414603008/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/MediaThrottler.java
(right):

https://codereview.chromium.org/1414603008/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/MediaThrottler.java:106:
try {
On 2015/10/30 21:54:37, Tima Vaisburd wrote:
> drive-by: The documentation does not seem to tell about exceptions at all, why
> not to catch all exceptions instead of just IllegalStateException?

if u check MediaPlayer.create(), it already catches IllegalArgumentException,
SecurityException and IOException