Source/core/rendering/TextAutosizer.h - Issue 14146029: Fix textarea font autosizing oscillation when the number of lines exceeds 4. The proposed fix is no…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/TextAutosizer.h

Issue 14146029: Fix textarea font autosizing oscillation when the number of lines exceeds 4. The proposed fix is no… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: autosize textareas by default Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/text-autosizing/textarea-fontsize-change-expected.html ('K') | « LayoutTests/fast/text-autosizing/textarea-fontsize-change-expected.html ('k') | Source/core/rendering/TextAutosizer.cpp » ('j') | Source/core/rendering/TextAutosizer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/TextAutosizer.h

diff --git a/Source/core/rendering/TextAutosizer.h b/Source/core/rendering/TextAutosizer.h

index 5b38d0748be1140f29dc23d1863850d8d648107d..5e1a96a8d4b20bb5be375814adbf7f9575d1c4be 100644

--- a/Source/core/rendering/TextAutosizer.h

+++ b/Source/core/rendering/TextAutosizer.h

@@ -79,6 +79,7 @@ private:

static bool containerShouldBeAutosized(const RenderBlock* container);

static bool containerContainsOneOfTags(const RenderBlock* cluster, const Vector<QualifiedName>& tags);

static bool containerIsRowOfLinks(const RenderObject* container);

+ static bool containerIsTextArea(const RenderBlock* container);

static bool contentHeightIsConstrained(const RenderBlock* container);

static bool clusterShouldBeAutosized(TextAutosizingClusterInfo&, float blockWidth);

static bool compositeClusterShouldBeAutosized(Vector<TextAutosizingClusterInfo>&, float blockWidth);