LayoutTests/fast/text-autosizing/textarea-fontsize-change-expected.html - Issue 14146029: Fix textarea font autosizing oscillation when the number of lines exceeds 4. The proposed fix is no…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text-autosizing/textarea-fontsize-change-expected.html

Issue 14146029: Fix textarea font autosizing oscillation when the number of lines exceeds 4. The proposed fix is no… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fixed John's comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html style="font-size: 16px">

	3 <head>

	4

	5 <meta name="viewport" content="width=800">

	6 <style>

	7 body {

	8 width: 800px;

	9 margin: 0;

	10 overflow-y: hidden;

	11 }

	12 </style>

	13

	14 </head>

	15 <body>

	16

	17 <textarea rows="12" style="width: 100%; font-size: 2.5rem">

	18 The text inside this textarea should be autosized. Lorem ipsum dolor sit amet, c onsectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolor e magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco labor is nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehender it in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sin t occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit ani m id est laborum.
	johnme 2013/05/01 11:34:39 Nit: like the other tests, it would be nice to exp Nit: like the other tests, it would be nice to explicitly say the expected size, e.g.: "The text inside this textarea should be autosized to 40px computed font-size (16 * 800/320)." timvolodine 2013/05/02 11:12:12 Done. Show quoted text On 2013/05/01 11:34:39, johnme wrote: > Nit: like the other tests, it would be nice to explicitly say the expected size, > e.g.: > > "The text inside this textarea should be autosized to 40px computed font-size > (16 * 800/320)." Done.
	19 </textarea>

	20

	21 </body>

	22 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/text-autosizing/textarea-fontsize-change.html ('k') | Source/core/rendering/TextAutosizer.cpp » ('j') | no next file with comments »