LayoutTests/fast/text-autosizing/textarea-fontsize-change-expected.html - Issue 14146029: Fix textarea font autosizing oscillation when the number of lines exceeds 4. The proposed fix is no…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text-autosizing/textarea-fontsize-change-expected.html

Issue 14146029: Fix textarea font autosizing oscillation when the number of lines exceeds 4. The proposed fix is no… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: autosize textareas by default Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/text-autosizing/textarea-fontsize-change.html ('k') | Source/core/rendering/TextAutosizer.h » ('j') | Source/core/rendering/TextAutosizer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html style="font-size: 16px">

	3 <head>

	4

	5 <meta name="viewport" content="width=800">

	6 <style>

	7 body {

	8 width: 800px;

	9 margin: 0;

	10 overflow-y: hidden;

	11 }

	12 </style>

	13

	14 </head>

	15 <body>

	16

	17 <textarea rows="12" style="width: 100%; font-size: 2.05rem">
	johnme 2013/04/29 11:11:26 This seems surprisingly small. I was expecting a v This seems surprisingly small. I was expecting a value closer to 800/320 = 2.5 (though it probably won't be exactly 2.5 due to the margins/borders of the textarea). Do you know how this got calculated? timvolodine 2013/04/29 17:59:13 It seems that the default font-size for the text a Show quoted text On 2013/04/29 11:11:26, johnme wrote: > This seems surprisingly small. I was expecting a value closer to 800/320 = 2.5 > (though it probably won't be exactly 2.5 due to the margins/borders of the > textarea). Do you know how this got calculated? It seems that the default font-size for the text area is smaller that that of body text. If I put an explicit font-size: 16px, then problem disappears and the factor becomes 2.5...
	18 The text inside this textarea should be autosized.

	19 Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostr ud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis au te irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qu i officia deserunt mollit anim id est laborum.

	20 </textarea>

	21

	22 </body>

	23 </html>

OLD	NEW